Skip to content

Regenerate gapic for Speech API, remove deprecated manual layer #4788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lukesneeringer merged 3 commits into from
Jan 30, 2018
Merged

Regenerate gapic for Speech API, remove deprecated manual layer #4788

lukesneeringer merged 3 commits into from
Jan 30, 2018

Conversation

@lukesneeringer
Copy link
Contributor

@lukesneeringer lukesneeringer commented Jan 25, 2018

  • Removes the deprecated manual layer.
  • Institutes new timeouts.
  • Removes gax.

Speech update:
1579974 
  * Removes the deprecated manual layer.
  * Institutes new timeouts.
  * Removes gax.
@lukesneeringer lukesneeringer self-assigned this Jan 25, 2018
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 25, 2018
@theacodes
Copy link
Contributor

theacodes commented Jan 25, 2018

Didn't speech have a small partial gapic for streaming recognize?

@chemelnucfin
Copy link
Contributor

chemelnucfin commented Jan 25, 2018

@lukesneeringer, what was confusing to me yesterday was that there are two SpeechClients, one was in speech/google/cloud/gapic and one was in speech/speech_v1 which imports the gapic one, which @jonparrott cleared up for me.

This still seems to have two, except that speech/google/cloud/gapic has been moved to speech/google/cloud/speech_v1/gapic, which can possibly be even more confusing. I could be wrong though.

@lukesneeringer
Copy link
Contributor Author

lukesneeringer commented Jan 25, 2018 •
edited
Loading

Didn't speech have a small partial gapic for streaming recognize?

speech_v1/helpers.py

@theacodes
Copy link
Contributor

theacodes commented Jan 25, 2018

Cool, LGTM

@lukesneeringer
Copy link
Contributor Author

lukesneeringer commented Jan 25, 2018

This still seems to have two

Yeah, that is fine. It is an unusual situation but the docs make pretty clear what to use.
Also, they are essentially identical outside of streaming.

@lukesneeringer
Copy link
Contributor Author

lukesneeringer commented Jan 25, 2018

Tagging do not merge based on a last-minute request from the API team.

@lukesneeringer lukesneeringer added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 25, 2018
@chemelnucfin chemelnucfin added the type: process A process-related concern. May include testing, release, or the like. label Jan 25, 2018
@theacodes theacodes changed the title Refresh Speech API Regenerate gapic for Speech API, remove deprecated manual layer Jan 26, 2018
@theacodes theacodes mentioned this pull request Jan 26, 2018
Closed
8 tasks
@lukesneeringer lukesneeringer removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 29, 2018
@lukesneeringer
Copy link
Contributor Author

lukesneeringer commented Jan 29, 2018

Reverted the config; waiting on CI.

@lukesneeringer lukesneeringer merged commit c845d69 into master Jan 30, 2018
@lukesneeringer lukesneeringer deleted the speech-update branch January 30, 2018 14:57
atulep pushed a commit that referenced this pull request Apr 3, 2023
@lukesneeringer
Regenerate gapic for Speech API, remove deprecated manual layer (#4788)
3ea3e20 
  * Removes the deprecated manual layer.
  * Institutes new timeouts.
  * Removes gax.
atulep pushed a commit that referenced this pull request Apr 18, 2023
@lukesneeringer
Regenerate gapic for Speech API, remove deprecated manual layer (#4788)
0eff0ea 
  * Removes the deprecated manual layer.
  * Institutes new timeouts.
  * Removes gax.
parthea pushed a commit that referenced this pull request Oct 22, 2023
@lukesneeringer
Regenerate gapic for Speech API, remove deprecated manual layer (#4788)
e1558ad 
  * Removes the deprecated manual layer.
  * Institutes new timeouts.
  * Removes gax.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@theacodes theacodes theacodes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@lukesneeringer lukesneeringer

Labels

cla: yes This human has signed the Contributor License Agreement. type: process A process-related concern. May include testing, release, or the like.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lukesneeringer @theacodes @chemelnucfin @googlebot