Skip to content

Release api_core v0.1.4 #4730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
theacodes merged 1 commit into from
Jan 11, 2018
Merged

Release api_core v0.1.4 #4730

theacodes merged 1 commit into from
Jan 11, 2018

Conversation

@theacodes
Copy link
Contributor

@theacodes theacodes commented Jan 10, 2018

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 10, 2018
dhermes
dhermes approved these changes Jan 10, 2018
View reviewed changes
Copy link
Contributor

@dhermes dhermes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but a few more things to update (if you please):

  • docs/core/releases.rst
  • datastore/setup.py (to depend on the "correct" version of api_core after #4702)
  • spanner/setup.py (#4695)

tseaver
tseaver approved these changes Jan 10, 2018
View reviewed changes
Copy link
Contributor

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theacodes
Copy link
Contributor Author

theacodes commented Jan 10, 2018

Do not merge, @dhermes and I are going to do something a little crazy.

@theacodes theacodes force-pushed the release-api_core-v0.2.0 branch from 2ecf68b to 0a6ff79 Compare January 10, 2018 22:52
@theacodes theacodes changed the title Release api_core v0.2.0 Release api_core v0.1.4 Jan 10, 2018
@theacodes
Copy link
Contributor Author

theacodes commented Jan 10, 2018

Needs to be rebased on top of #4731 and then we can merge.

@theacodes theacodes mentioned this pull request Jan 10, 2018
Merged
@dhermes
Copy link
Contributor

dhermes commented Jan 10, 2018

Still LGTM when #4731 is in

@theacodes theacodes force-pushed the release-api_core-v0.2.0 branch from 0a6ff79 to d0d4b8b Compare January 11, 2018 00:56
@theacodes
Copy link
Contributor Author

theacodes commented Jan 11, 2018

Rebased and good to merge when CI is green.

@theacodes theacodes merged commit 9e91b4c into master Jan 11, 2018
@theacodes theacodes deleted the release-api_core-v0.2.0 branch January 11, 2018 17:14
@theacodes theacodes mentioned this pull request Jan 11, 2018
Closed
9 tasks
parthea pushed a commit that referenced this pull request Nov 24, 2025
Release api_core v0.1.4 (#4730)
3fad2bc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@duggelz duggelz Awaiting requested review from duggelz

@liyanhui1228 liyanhui1228 Awaiting requested review from liyanhui1228

@lukesneeringer lukesneeringer Awaiting requested review from lukesneeringer

@tswast tswast Awaiting requested review from tswast

@waprin waprin Awaiting requested review from waprin

2 more reviewers

@tseaver tseaver tseaver approved these changes

@dhermes dhermes dhermes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: core cla: yes This human has signed the Contributor License Agreement. packaging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@theacodes @dhermes @tseaver @googlebot