@jbolinger You need to update setup.py as well.

Context: see #4633, where I added the .dev1 suffix to the version (this should be the "almost always" state of version numbers).

It looks good now since you've already changed it

I mean that if you want to cut the release, you need to drop the .dev1 suffix.

@jbolinger Also I just realized you pushed to the GoogleCloudPlatform:dataproc_release2 branch. Can you send PRs from your fork, rather than the main repo? (The exceptions to this rule are PRs where you want to see the system tests run or PRs where you are updating the gh-pages branch.)

@dhermes - got it, thanks. It looks like some of the other releases outside dataproc still have the suffix hence the confusion.

@jbolinger A "release" here just refers to the specific point in the history where we add the tag. For example, at the pubsub-0.30.0 tag, there is no version suffix:

setup(
    name='google-cloud-pubsub',
    version='0.30.0',
    ...
)

but I immediately followed up that release with #4624 to revert the version to "dev mode" / "not release mode".

So all of our packages should have the suffix in a "normal" state:

$ git log -1 --pretty=%H
4e50bba46ec58c1244516b06cac7ba7af37aafb7
$ git grep -n 'version=' -- '*setup.py'
api_core/setup.py:71:    version='0.1.3.dev1',
bigquery/setup.py:67:    version='0.28.1.dev1',
bigquery_datatransfer/setup.py:38:    version='0.1.1.dev1',
bigtable/setup.py:61:    version='0.28.2.dev1',
container/setup.py:38:    version='0.1.1.dev1',
core/setup.py:63:    version='0.28.1.dev1',
dataproc/setup.py:37:    version='0.1.0.dev1',
datastore/setup.py:64:    version='1.4.1.dev1',
dns/setup.py:60:    version='0.28.1.dev1',
error_reporting/setup.py:62:    version='0.28.1.dev1',
firestore/setup.py:60:    version='0.28.1.dev1',
language/setup.py:63:    version='1.0.1.dev1',
logging/setup.py:61:    version='1.4.1.dev1',
monitoring/setup.py:60:    version='0.28.1.dev1',
pubsub/setup.py:62:    version='0.30.1.dev1',
resource_manager/setup.py:60:    version='0.28.1.dev1',
runtimeconfig/setup.py:60:    version='0.28.1.dev1',
setup.py:79:    version='0.32.1.dev1',
spanner/setup.py:64:    version='0.29.1.dev1',
speech/setup.py:62:    version='0.30.1.dev1',
storage/setup.py:63:    version='1.6.1.dev1',
test_utils/setup.py:58:    version='0.24.0',
trace/setup.py:32:    version='0.17.1.dev1',
translate/setup.py:60:    version='1.3.1.dev1',
videointelligence/setup.py:32:    version='1.0.1.dev1',
vision/setup.py:42:    version='0.29.1.dev1',

(test_utils isn't a package we publish, so it's version is "Meh")

Yup, I got it. I'll add some notes to the release doc so that this convention is clear.

Yup, I got it. I'll add some notes to the release doc so that this convention is clear.

Thanks a lot! This blog post is the original motivation for that practice (if people are wondering when reading the release doc).

Oops, I said I would document some of this last week, didn't I? Sorry, been swamped with pre-Christmas App Engine stuff (and still swamped unfortunately).

@duggelz No worries!

I have checked over this and am about to actually cut this release.