Fix build issue with dataproc docs. #4633
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: - Fix an ambiguous name (`type`) in Pub / Sub (was introduced because I merged with the docs build failing) - Marking the `dataproc` version as `.dev1`
dhermes
added
documentation
packaging
type: cleanup
googlebot
added
the
cla: yes
dhermes
changed the title
Contributor
Author
|
I am going to merge this pre-review since it fixes the docs build which is currently breaking every build. |
Contributor
|
Thanks! We merged prior to docs because our build was failing on Spanner. Mea culpa. |
Contributor
Author
|
@lukesneeringer Totally get it (but the Spanner issue had been fixed in |
Contributor
|
Wait, the #4853 on master that failed which said Spanner failed on pubsub. The previous build was fine, and the subsequent one failed on docs... Which one is failing on spanner? |
Contributor
Author
|
@chemelnucfin See #4626 (comment). All is well in GitHub-town. |
parthea
pushed a commit
that referenced
this pull request
Sep 22, 2023
Also: - Fix an ambiguous name (`type`) in Pub / Sub (was introduced because I merged with the docs build failing) - Marking the `dataproc` version as `.dev1`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also:
type) in Pub / Sub (was introducedbecause I merged with the docs build failing)
dataprocversion as.dev1