Skip to content

Conversation

@chemelnucfin
Copy link
Contributor

Merge #4618 first. I still need to test this.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 19, 2017
@chemelnucfin chemelnucfin force-pushed the spanner_system_partial_ranges branch from 192fbcc to 95d1dbc Compare December 20, 2017 02:37
@chemelnucfin chemelnucfin added the api: spanner Issues related to the Spanner API. label Dec 20, 2017
@chemelnucfin chemelnucfin force-pushed the spanner_system_partial_ranges branch from 95d1dbc to 56ba721 Compare December 20, 2017 18:05
@dhermes dhermes force-pushed the spanner_system_partial_ranges branch from 56ba721 to dd4222e Compare December 20, 2017 18:22
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Dec 20, 2017
Copy link
Contributor

@dhermes dhermes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chemelnucfin
Copy link
Contributor Author

Ugh, I wrote tests in a loop style before and it was not allowed.

@dhermes dhermes merged commit 157b498 into googleapis:master Dec 20, 2017
@dhermes
Copy link
Contributor

dhermes commented Dec 20, 2017

Ugh, I wrote tests in a loop style before and it was not allowed.

Sorry to hear that. I am OK with it.

@tseaver
Copy link
Contributor

tseaver commented Dec 20, 2017

FWIW, the reason I asked @chemelnucfin to remove them elsewhere is that the loops introduce a lot of noise, and make debugging failures harder: those tests are "speed bumps" for readers.

@chemelnucfin chemelnucfin added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Dec 20, 2017
@chemelnucfin
Copy link
Contributor Author

I don't have a preference for either style. I can see merits and drawbacks in both.

@dhermes
Copy link
Contributor

dhermes commented Dec 20, 2017

@tseaver I somewhat agree with you, but the copy-pasta creates other issues.

I am 100% for switching to pytest style, then we can use pytest.mark.parameterize to have one test but multiple data.

@tseaver tseaver mentioned this pull request Dec 20, 2017
19 tasks
@chemelnucfin chemelnucfin deleted the spanner_system_partial_ranges branch December 25, 2017 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants