-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Spanner: System test partial range #4631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spanner: System test partial range #4631
Conversation
192fbcc to
95d1dbc
Compare
95d1dbc to
56ba721
Compare
56ba721 to
dd4222e
Compare
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
dhermes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Ugh, I wrote tests in a loop style before and it was not allowed. |
Sorry to hear that. I am OK with it. |
|
FWIW, the reason I asked @chemelnucfin to remove them elsewhere is that the loops introduce a lot of noise, and make debugging failures harder: those tests are "speed bumps" for readers. |
|
I don't have a preference for either style. I can see merits and drawbacks in both. |
|
@tseaver I somewhat agree with you, but the copy-pasta creates other issues. I am 100% for switching to |
Merge #4618 first. I still need to test this.