Spanner: More keyset tests #4623
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
chemelnucfin
force-pushed
the
spanner_double_keys
branch
from
508e2a4 to
67e5493
Compare
chemelnucfin
force-pushed
the
spanner_double_keys
branch
from
67e5493 to
6ae2509
Compare
dhermes
reviewed
Dec 19, 2017
| def _make_one(self, *args, **kwargs): | ||
| return self._getTargetClass()(*args, **kwargs) | ||
|
|
||
| def _check_unused_keys(self, krange, used_keys): |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| self.assertEqual(len(krange_pb.end_closed), 1) | ||
| self.assertEqual(krange_pb.end_closed.values[0].string_value, KEY_2[0]) | ||
|
|
||
| def test_ctor_empty_list_start_closed_and_key_end_closed(self): |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
Author
|
Going to close this for now. I might add the tests back in later if necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
breaking up #4515