Skip to content

Stop using a non-public grpcio API in Spanner tests. #4620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dhermes merged 1 commit into from
Dec 19, 2017
Merged

Stop using a non-public grpcio API in Spanner tests. #4620

dhermes merged 1 commit into from
Dec 19, 2017

Conversation

@dhermes
Copy link
Contributor

@dhermes dhermes commented Dec 18, 2017

Fixes #4580.

@dhermes dhermes added api: spanner Issues related to the Spanner API. type: cleanup An internal cleanup or hygiene concern. labels Dec 18, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 18, 2017
@chemelnucfin
Copy link
Contributor

chemelnucfin commented Dec 18, 2017

LGTM

@dhermes dhermes merged commit 2edd612 into googleapis:master Dec 19, 2017
@dhermes dhermes deleted the fix-4580 branch December 19, 2017 00:02
@dhermes dhermes mentioned this pull request Dec 19, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukesneeringer lukesneeringer Awaiting requested review from lukesneeringer

Assignees

@lukesneeringer lukesneeringer

@tseaver tseaver

Labels

api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement. type: cleanup An internal cleanup or hygiene concern.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dhermes @chemelnucfin @lukesneeringer @tseaver @googlebot