Do not use easily-misread glyphs in Firestore auto-IDs. #4590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way the entropy is preserved after dropping the alphabet from 62 to 55 characters: >>> (62. / 55.)**20 10.979435205204474 >>> 55**20 < 62**20 < 55**21 True
dhermes
added
api: firestore
googlebot
added
the
cla: yes
lukesneeringer
approved these changes
Dec 14, 2017
Contributor
Author
|
@lukesneeringer This is the 3rd time you or I have sent this PR (once was in a private repo) 😀 The previous two were a no-go because we were waiting for a thumbs up from the Firestore team. |
Contributor
|
@lukesneeringer @dhermes My fault. I just thought it has been approved and was just sitting, so I merged it. |
chemelnucfin
added
do not close
do not merge
Contributor
|
@dhermes This is a pretty minor change. Either merge it or close it and let's move on with our lives. :-) |
schmidt-sebastian
approved these changes
Dec 21, 2017
| self.assertEqual(result, mock_result) | ||
|
|
||
| mock_calls = [mock.call(_AUTO_ID_CHARS)] * 20 | ||
| mock_calls = [mock.call(_AUTO_ID_CHARS)] * 21 |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
{'i', 'I', 'l', 'o', 'O', '0', '1'}from the set of characters used in automatically-generated IDs, because it is easy to mis-read them if you are in a situation where you need to do that.Exact set of blacklisted characters is loaned from Django's
make_random_password./cc @schmidt-sebastian
Was #4107