Storage: Fix coverage issue #4544
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Contributor
|
@chemelnucfin This is not needed. |
Contributor
Author
|
But when you test just a single version, you will wonder what you are missing. |
Contributor
|
That's not the point? |
Contributor
Author
|
But it does require extra time to confirm that it wasn't what you did that lowered the coverage, right? |
Contributor
|
@chemelnucfin I don't follow. Run |
Contributor
Author
|
Is there something wrong with the test though? It does fix the coverage issue. |
Contributor
It's the tail wagging the dog. We (our code) shouldn't work around our tools / language versions, they should work around us.
There is no coverage issue to fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this is "desired", but it does make the coverage to be 100%.