Skip to content

Preparing release 0.17.0 of trace #4538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
liyanhui1228 merged 2 commits into from
Dec 7, 2017
Merged

Preparing release 0.17.0 of trace #4538

liyanhui1228 merged 2 commits into from
Dec 7, 2017

Conversation

@liyanhui1228
Copy link
Contributor

@liyanhui1228 liyanhui1228 commented Dec 7, 2017 •
edited
Loading

@dhermes I need to bump the version number from 0.16.0 to 0.17.0 to avoid breaking the OpenCensus package which is depending on google-cloud-trace>=0.16.0, <0.17dev. Could you do a release for the trace package? Thanks a lot!

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 7, 2017
dhermes
dhermes reviewed Dec 7, 2017
View reviewed changes
Copy link
Contributor

@dhermes dhermes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update docs/trace/releases.rst

I'll be happy to push a tag for you once this is merged, though you can do this too if you have GitHub privileges for creating a tag (the tag would be trace-0.17.0)

trace/CHANGELOG.md Outdated

- Default to use Stackdriver Trace V2 API if calling `from google.cloud import trace`.
Using V1 API needs to be explicitly specified in the import.(#4437)
- Comparing `datetime.datetime`-s in trace unit tests. (#4323)

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

trace/CHANGELOG.md

PyPI: https://pypi.org/project/google-cloud-trace/0.16.0/

## 0.17.0

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@liyanhui1228
Copy link
Contributor Author

liyanhui1228 commented Dec 7, 2017 •
edited
Loading

@dhermes Thanks for your review, I have updated the releases.rst and addressed the comments. I just checked that I can create the tag after this is merged.

dhermes
dhermes approved these changes Dec 7, 2017
View reviewed changes
Copy link
Contributor

@dhermes dhermes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liyanhui1228 liyanhui1228 merged commit 67e8c54 into googleapis:master Dec 7, 2017
@liyanhui1228
Copy link
Contributor Author

liyanhui1228 commented Dec 7, 2017

@dhermes I don't have the account to push packages to Pypi, will need your help. Thx!

@liyanhui1228 liyanhui1228 deleted the release-trace branch December 7, 2017 00:43
@dhermes
Copy link
Contributor

dhermes commented Dec 7, 2017

@liyanhui1228 The build will do that.

@liyanhui1228
Copy link
Contributor Author

liyanhui1228 commented Dec 7, 2017

@dhermes Great!

parthea pushed a commit that referenced this pull request Oct 22, 2023
@liyanhui1228
Preparing release 0.17.0 of trace (#4538)
d8a1586
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@duggelz duggelz Awaiting requested review from duggelz

@lukesneeringer lukesneeringer Awaiting requested review from lukesneeringer

1 more reviewer

@dhermes dhermes dhermes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@liyanhui1228 @dhermes @googlebot