Skip to content

Conversation

@dhermes
Copy link
Contributor

@dhermes dhermes commented Dec 4, 2017

This reverts commit 5a0e549 / PR #3811.

See: #3811 (comment)

/cc @calpeyser @igorbernstein2 @sduskis

@igorbernstein2 I'll push a new branch that actually has the contents of #3811 in it and then we can change the base in #4443 from master to that branch? Then once #4443 is merged we can merge that branch back into master?

@dhermes dhermes added the api: bigtable Issues related to the Bigtable API. label Dec 4, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 4, 2017
@igorbernstein2
Copy link

Sorry for the radio silence. I've been a bit swamped, we are working with a contractor that will be able to take a look at it

@dhermes
Copy link
Contributor Author

dhermes commented Dec 4, 2017

@igorbernstein2 No worries. I just wanted our build to go back green. If bigtable didn't get run with the whole build it wouldn't be the same sort of issue. (And we are splitting the repo up into N repos, one for each package, soon.)

This feature was prioritized by the Bigtable team, so feel free to take your time. (I.e. no one on the library side is feeling time pressured to land it.)

@dhermes dhermes merged commit dfe8a41 into master Dec 4, 2017
@dhermes dhermes deleted the revert-3811 branch December 4, 2017 19:15
parthea pushed a commit that referenced this pull request Nov 22, 2025
This reverts commit 1c699f36584d8c507118dae9ab8a2a31bc951ce6 / PR #3811.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants