Skip to content

BigTable: try resetting BIGTABLE_EMULATOR_HOST to fix bigtable test errors #4443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
igorbernstein2 wants to merge 1 commit into from
Closed

BigTable: try resetting BIGTABLE_EMULATOR_HOST to fix bigtable test errors #4443

igorbernstein2 wants to merge 1 commit into from

Conversation

@igorbernstein2
Copy link

@igorbernstein2 igorbernstein2 commented Nov 22, 2017

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 22, 2017
@igorbernstein2
Copy link
Author

igorbernstein2 commented Nov 22, 2017

I couldn't reproduce the test failures locally, so I'm not sure if this is the actual cause of the issues.

dhermes
dhermes reviewed Nov 22, 2017
View reviewed changes
Copy link
Contributor

@dhermes dhermes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@igorbernstein2 Instead, can you use

@mock.patch('os.environ', new={})
def test_retry(self):
    ...

This way, any changes you make to os.environ in this method will be isolated.

Also, as far as reproducing, you can use the same Docker image our tests run in:

docker run \
  --rm \
  --tty \
  --interactive \
  --volume $(git rev-parse --show-toplevel):/var/code/gcp/ \
  googleapis/nox:0.17.0 \
  /bin/bash

(This won't help you decode the credentials file, but I'm happy to chat about how you might get one of those if you're not familiar.)

@chemelnucfin chemelnucfin added the api: bigtable Issues related to the Bigtable API. label Nov 23, 2017
@chemelnucfin chemelnucfin changed the title try resetting BIGTABLE_EMULATOR_HOST to fix bigtable test errors BigTable: try resetting BIGTABLE_EMULATOR_HOST to fix bigtable test errors Nov 23, 2017
@dhermes dhermes mentioned this pull request Dec 4, 2017
Merged
@dhermes dhermes changed the base branch from master to pr-3811 December 4, 2017 18:43
@dhermes
Copy link
Contributor

dhermes commented Dec 4, 2017

@igorbernstein2 Since #3811 will be (temporarily) reverted, I have changed the base of this PR from master to pr-3811 (a branch in the main remote that has the changes from #3811 still)

@chemelnucfin chemelnucfin added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Jan 15, 2018
@tseaver tseaver removed type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Feb 20, 2018
@theacodes
Copy link
Contributor

theacodes commented Feb 22, 2018

I'm closing this for now. It's been open since last year and no movement, and as far as I know our bigtable tests are passing.

Feel free to comment if this is still relevant.

@theacodes theacodes closed this Feb 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukesneeringer lukesneeringer Awaiting requested review from lukesneeringer

1 more reviewer

@dhermes dhermes dhermes left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@igorbernstein2 @dhermes @theacodes @tseaver @chemelnucfin @googlebot