Skip to content

Logging: pass in parameters to workers #4369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chemelnucfin merged 2 commits into from
Nov 9, 2017
Merged

Logging: pass in parameters to workers #4369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18b7240
closes #4365 - pass in parameters to workers
chemelnucfin Nov 9, 2017
26699ed
review changes
chemelnucfin Nov 9, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion logging/google/cloud/logging/handlers/transports/background_thread.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,9 @@ def __init__(self, client, name, grace_period=_DEFAULT_GRACE_PERIOD,
batch_size=_DEFAULT_MAX_BATCH_SIZE):
self.client = client
logger = self.client.logger(name)
self.worker = _Worker(logger)
self.worker = _Worker(logger,
grace_period=grace_period,
max_batch_size=batch_size)
self.worker.start()

def send(self, record, message, resource=None, labels=None):
Expand Down
16 changes: 16 additions & 0 deletions logging/tests/unit/handlers/transports/test_background_thread.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,22 @@ def test_flush(self):

transport.worker.flush.assert_called()

def test_worker(self):
client = _Client(self.PROJECT)
name = 'python_logger'
batch_size = 30
grace_period = 20.
transport, worker = self._make_one(client,
name,
grace_period=grace_period,
batch_size=batch_size)
worker_grace_period = worker.call_args[1]['grace_period'] # **kwargs.
worker_batch_size = worker.call_args[1]['max_batch_size']
self.assertEqual(worker_grace_period,
grace_period)
self.assertEqual(worker_batch_size,
batch_size)


class Test_Worker(unittest.TestCase):
NAME = 'python_logger'
Expand Down