Logging: pass in parameters to workers#4369
Merged
chemelnucfin merged 2 commits intoNov 9, 2017
Merged
Conversation
googlebot
added
the
cla: yes
chemelnucfin
changed the title
tseaver
suggested changes
Nov 9, 2017
|
|
||
| def __init__(self, client, name, grace_period=_DEFAULT_GRACE_PERIOD, | ||
| batch_size=_DEFAULT_MAX_BATCH_SIZE): | ||
| max_batch_size=_DEFAULT_MAX_BATCH_SIZE): |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| self.worker = _Worker(logger) | ||
| self.worker = _Worker(logger, | ||
| grace_period=grace_period, | ||
| max_batch_size=max_batch_size) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
Author
|
@tseaver PTAL at your convenience, thanks! |
tseaver
approved these changes
Nov 9, 2017
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
* closes #4365 - pass in parameters to workers * review changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #4365 - Not sure if this is autogenerated though.