Handle retry=None for mutate_rows, and some refactoring in test #4341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raise a custom error for Retry strategy instead of a fake standard error.
googlebot
added
the
cla: yes
Contributor
Author
|
This is also a follow up on #4256 |
dhermes
reviewed
Nov 3, 2017
bigtable/tests/unit/test_table.py
Outdated
| SUCCESS = 0 | ||
| RETRYABLE_1 = 4 | ||
| RETRYABLE_2 = 10 | ||
| NON_RETRYABLE = 1 |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
theacodes
approved these changes
Nov 3, 2017
Contributor
Author
|
@dhermes Can you help setting the relevant label(s) to the PR? Should we normally set assignee as well? I could update neither though. |
lukesneeringer
approved these changes
Nov 6, 2017
tseaver
added
api: bigtable
chemelnucfin
pushed a commit
to chemelnucfin/google-cloud-python
that referenced
this pull request
Nov 6, 2017
parthea
pushed a commit
that referenced
this pull request
Nov 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @dhermes
As discussed in #4333, this change addresses the input retry=None for
mutate_rows. @jonparrott I made an internal error_BigtableRetryableErrorand have it be used to trigger the retry instead of raising a fakeSerivceUnavailable. Would like to get your opinion regarding this use.Also factored out test response creation and replaced the magic numbers with constants for RPC Status Code. And removed the extra
thefrom the error message.