Skip to content

Comparing datetime.datetime-s in trace unit tests. #4323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dhermes merged 1 commit into from
Nov 1, 2017
Merged

Comparing datetime.datetime-s in trace unit tests. #4323

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 23 additions & 20 deletions trace/tests/unit/test__gax.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

import datetime
import unittest

import mock
Expand Down Expand Up @@ -46,13 +47,11 @@ def test_patch_traces(self):
from google.cloud.trace._gax import _traces_mapping_to_pb
from google.cloud._helpers import _datetime_to_pb_timestamp

from datetime import datetime

trace_id = 'test_trace_id'
span_id = 1234
span_name = 'test_span_name'
start_time = datetime.utcnow()
end_time = datetime.utcnow()
start_time = datetime.datetime.utcnow()
end_time = datetime.datetime.utcnow()

traces = {
'traces': [
Expand Down Expand Up @@ -157,20 +156,20 @@ def _make_trace_pb(
return trace_pb

def test_list_traces_no_paging(self):
from google.cloud._helpers import _rfc3339_to_datetime
from google.cloud._helpers import UTC
from google.cloud._testing import _GAXPageIterator
from google.cloud.gapic.trace.v1 import trace_service_client
from google.cloud.gapic.trace.v1.enums import ListTracesRequest as Enum
from google.gax import INITIAL_PAGE

from datetime import datetime

trace_id = 'test_trace_id'
span_id = 1234
span_name = 'test_span_name'
span_kind = 'RPC_CLIENT'
parent_span_id = 123
start_time = datetime.utcnow().isoformat() + 'Z'
end_time = datetime.utcnow().isoformat() + 'Z'
start_ts = datetime.datetime.utcnow()
end_ts = datetime.datetime.utcnow()
labels = {
'/http/status_code': '200',
'/component': 'HTTP load balancer',
Expand All @@ -183,8 +182,8 @@ def test_list_traces_no_paging(self):
trace_id,
span_id,
span_name,
start_time,
end_time,
start_ts.isoformat() + 'Z',
end_ts.isoformat() + 'Z',
parent_span_id,
labels)

Expand Down Expand Up @@ -213,9 +212,11 @@ def test_list_traces_no_paging(self):
self.assertEqual(span['name'], span_name)

self.assertEqual(
span['startTime'], start_time)
_rfc3339_to_datetime(span['startTime']),
start_ts.replace(tzinfo=UTC))
self.assertEqual(
span['endTime'], end_time)
_rfc3339_to_datetime(span['endTime']),
end_ts.replace(tzinfo=UTC))
self.assertEqual(span['kind'], span_kind)
self.assertEqual(span['parentSpanId'], str(parent_span_id))
self.assertEqual(span['labels'], labels)
Expand All @@ -232,19 +233,19 @@ def test_list_traces_no_paging(self):
self.assertEqual(call_args['options'].page_token, INITIAL_PAGE)

def test_list_traces_with_paging(self):
from google.cloud._helpers import _rfc3339_to_datetime
from google.cloud._helpers import UTC
from google.cloud._testing import _GAXPageIterator
from google.cloud.gapic.trace.v1 import trace_service_client
from google.cloud.gapic.trace.v1.enums import ListTracesRequest as Enum

from datetime import datetime

trace_id = 'test_trace_id'
span_id = 1234
span_name = 'test_span_name'
span_kind = 'RPC_CLIENT'
parent_span_id = 123
start_time = datetime.utcnow().isoformat() + 'Z'
end_time = datetime.utcnow().isoformat() + 'Z'
start_ts = datetime.datetime.utcnow()
end_ts = datetime.datetime.utcnow()
labels = {
'/http/status_code': '200',
'/component': 'HTTP load balancer',
Expand All @@ -258,8 +259,8 @@ def test_list_traces_with_paging(self):
trace_id,
span_id,
span_name,
start_time,
end_time,
start_ts.isoformat() + 'Z',
end_ts.isoformat() + 'Z',
parent_span_id,
labels)

Expand Down Expand Up @@ -289,9 +290,11 @@ def test_list_traces_with_paging(self):
self.assertEqual(span['name'], span_name)

self.assertEqual(
span['startTime'], start_time)
_rfc3339_to_datetime(span['startTime']),
start_ts.replace(tzinfo=UTC))
self.assertEqual(
span['endTime'], end_time)
_rfc3339_to_datetime(span['endTime']),
end_ts.replace(tzinfo=UTC))
self.assertEqual(span['kind'], span_kind)
self.assertEqual(span['parentSpanId'], str(parent_span_id))
self.assertEqual(span['labels'], labels)
Expand Down