Be permissive about merging an empty list. #4170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
tseaver
reviewed
Oct 12, 2017
Contributor
tseaver
left a comment
tseaver
left a comment
There was a problem hiding this comment.
In what sane world does the back-end return an empty chunk?
|
|
||
| # Sanity check: If either list is empty, short-circuit. | ||
| # This is effectively a no-op. | ||
| if not len(lhs) or not len(rhs): |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
|
@lukesneeringer #4169 is merged to master: can you rebase? |
lukesneeringer
force-pushed
the
issue-4164
branch
from
8447df0 to
0f8e524
Compare
Contributor
Author
|
Done. Will merge once tests run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4164.
(Uses #4169 as a de facto base.)