-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add scope for trace client #4158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dhermes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@dhermes Could you please do a release for the trace package? Thanks! |
|
@liyanhui1228 Can you draft some release notes, in the style of https://github.com/GoogleCloudPlatform/google-cloud-python/releases/tag/storage-1.3.0? You can run to decide what should go in the release notes I'm not sure a release will be easy, |
|
@dhermes The release notes can just be empty like what we did in last release :) |
|
We should always publish release notes when we make releases, even if the changes are trivial. |
|
@jonparrott Thanks! I drafted the release note like below, Notable Implementation Changes
Packaging
|
|
@liyanhui1228 I'd be fine leaving the deps changes out of the release notes. What about #3922? (It looks like @lukesneeringer intended there to be a |
|
@dhermes OK! I removed the dependencies notes, and added packaging note. |
|
Friendly ping. |
|
I made https://github.com/GoogleCloudPlatform/google-cloud-python/tree/trace-cherry-pick to avoid being gated on commit 863d293f16f7df1962a4a367b8bf913daefe02fe
Author: Danny Hermes <daniel.j.hermes@gmail.com>
Date: Fri Oct 13 15:33:01 2017 -0700
Rolling back the dependency update for trace.
This is so that an "off-master" release can be done
without being gated on a `google-cloud-core` release.
diff --git a/trace/setup.py b/trace/setup.py
index c14fbbe..8072778 100644
--- a/trace/setup.py
+++ b/trace/setup.py
@@ -9,7 +9,8 @@ from setuptools import setup, find_packages
install_requires = [
'google-gax>=0.15.7, <0.16dev',
- 'google-cloud-core[grpc] >= 0.27.1, < 0.28dev',
+ 'googleapis-common-protos[grpc]>=1.5.2, <2.0dev',
+ 'google-cloud-core >= 0.27.0, < 0.28dev',
]
setup( |
|
Thanks! So this release will be based on the |
|
The branch is now deleted and immortalized as https://github.com/GoogleCloudPlatform/google-cloud-python/releases/tag/trace-0.15.5. This build (https://circleci.com/gh/GoogleCloudPlatform/google-cloud-python/3757) should push to PyPI. |
Adding the scope needed when setting credentials file via
$GOOGLE_APPLICATION_CREDENTIALS.