Skip to content

bigquery: add Client.list_rows, remove Table.fetch_data #4119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jba merged 1 commit into from
Oct 6, 2017
Merged

bigquery: add Client.list_rows, remove Table.fetch_data #4119

jba merged 1 commit into from
Oct 6, 2017

Conversation

@jba
Copy link
Contributor

@jba jba commented Oct 4, 2017

No description provided.

@jba jba requested review from alixhami, tseaver and tswast October 4, 2017 18:52
@jba jba requested a review from lukesneeringer as a code owner October 4, 2017 18:52
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 4, 2017
tswast
tswast requested changes Oct 4, 2017
View reviewed changes
bigquery/google/cloud/bigquery/client.py
The fields to return. Required if ``table`` is a
:class:`~google.cloud.bigquery.table.TableReference`.
:type max_results: int

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

bigquery/google/cloud/bigquery/client.py Outdated
:class:`~google.cloud.bigquery.table.TableReference`.
:type max_results: int
:param max_results: (Optional) Maximum number of rows to return.

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

bigquery/tests/unit/test_client.py
local_number = SchemaField('local_number', 'STRING', 'REQUIRED')
rank = SchemaField('rank', 'INTEGER', 'REQUIRED')
phone = SchemaField('phone', 'RECORD', mode='NULLABLE',
fields=[area_code, local_number, rank])

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

tswast
tswast reviewed Oct 5, 2017
View reviewed changes
bigquery/google/cloud/bigquery/client.py
items_key='rows',
page_token=page_token,
next_token='pageToken',
max_results=max_results,

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@jba jba merged commit 7e2f538 into googleapis:bigquery-b2 Oct 6, 2017
tswast pushed a commit that referenced this pull request Oct 12, 2017
@jba @tswast
bigquery: add Client.list_rows, remove Table.fetch_data (#4119)
ccf0ec2
tswast pushed a commit that referenced this pull request Oct 16, 2017
@jba @tswast
bigquery: add Client.list_rows, remove Table.fetch_data (#4119)
3a99312
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tswast tswast tswast approved these changes

@tseaver tseaver Awaiting requested review from tseaver

@alixhami alixhami Awaiting requested review from alixhami

@lukesneeringer lukesneeringer Awaiting requested review from lukesneeringer

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jba @tswast @googlebot