Skip to content

Use POST with Translate API #4095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukesneeringer merged 1 commit into from
Oct 2, 2017
Merged

Use POST with Translate API #4095

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion translate/google/cloud/translate_v2/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ def translate(self, values, target_language=None, format_=None,
query_params.append(('model', model))

response = self._connection.api_request(
method='GET', path='', query_params=query_params)
method='POST', path='', query_params=query_params)

translations = response.get('data', {}).get('translations', ())
if len(values) != len(translations):
Expand Down
8 changes: 4 additions & 4 deletions translate/tests/unit/test_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ def test_translate_bad_result(self):
# Verify requested.
self.assertEqual(len(conn._requested), 1)
req = conn._requested[0]
self.assertEqual(req['method'], 'GET')
self.assertEqual(req['method'], 'POST')
self.assertEqual(req['path'], '')
query_params = [
('target', 'en'),
Expand Down Expand Up @@ -278,7 +278,7 @@ def test_translate_defaults(self):
# Verify requested.
self.assertEqual(len(conn._requested), 1)
req = conn._requested[0]
self.assertEqual(req['method'], 'GET')
self.assertEqual(req['method'], 'POST')
self.assertEqual(req['path'], '')
query_params = [
('target', 'en'),
Expand Down Expand Up @@ -313,7 +313,7 @@ def test_translate_multiple(self):
# Verify requested.
self.assertEqual(len(conn._requested), 1)
req = conn._requested[0]
self.assertEqual(req['method'], 'GET')
self.assertEqual(req['method'], 'POST')
self.assertEqual(req['path'], '')
query_params = [
('target', 'en'),
Expand Down Expand Up @@ -350,7 +350,7 @@ def test_translate_explicit(self):
# Verify requested.
self.assertEqual(len(conn._requested), 1)
req = conn._requested[0]
self.assertEqual(req['method'], 'GET')
self.assertEqual(req['method'], 'POST')
self.assertEqual(req['path'], '')
query_params = [
('target', target_language),
Expand Down