Skip to content

Delete demo keys, update demos to use same environment vars as regressions - #383

Merged
tseaver merged 3 commits into
googleapis:masterfrom
tseaver:remove_demo_key
Nov 24, 2014
Merged

tseaver merged 3 commits into
googleapis:masterfrom
tseaver:remove_demo_key

Conversation

@tseaver

@tseaver tseaver commented Nov 24, 2014

Copy link
Copy Markdown
Contributor

No description provided.

@tseaver

tseaver commented Nov 24, 2014

Copy link
Copy Markdown
Contributor Author

I have tested that both demos run successfully with the variables set in the environment. I don't know if we need to emit nicer error messages if they aren't set.

This comment was marked as spam.

@dhermes

dhermes commented Nov 24, 2014

Copy link
Copy Markdown
Contributor

@tseaver We need to update the documentation as well.

@tseaver

tseaver commented Nov 24, 2014

Copy link
Copy Markdown
Contributor Author

@dhermes Re: docs: 73885a3

@dhermes

dhermes commented Nov 24, 2014

Copy link
Copy Markdown
Contributor

LGTM pending Travis

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same when pulling 73885a3 on tseaver:remove_demo_key into 42a0f2d on GoogleCloudPlatform:master.

tseaver added a commit that referenced this pull request Nov 24, 2014
Delete demo keys, update demos to use same environment vars as regressions
@tseaver
tseaver merged commit d62d186 into googleapis:master Nov 24, 2014
@tseaver
tseaver deleted the remove_demo_key branch November 24, 2014 22:05
@dhermes dhermes added the api: datastore Issues related to the Datastore API. label Dec 31, 2015
parthea pushed a commit that referenced this pull request Jun 4, 2023
- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 451250442

Source-Link: googleapis/googleapis@cca5e81

Source-Link: googleapis/googleapis-gen@0b219da
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMGIyMTlkYTE2MWE4YmRjYzNjNmY3YjJlZmNkODIxMDUxODJhMzBjYSJ9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: datastore Issues related to the Datastore API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants