Repository navigation
Delete demo keys, update demos to use same environment vars as regressions - #383
Merged
Merged
Conversation
Contributor
Author
|
I have tested that both demos run successfully with the variables set in the environment. I don't know if we need to emit nicer error messages if they aren't set. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
|
@tseaver We need to update the documentation as well. |
Contributor
Author
Contributor
|
LGTM pending Travis |
tseaver
added a commit
that referenced
this pull request
Nov 24, 2014
Delete demo keys, update demos to use same environment vars as regressions
parthea
pushed a commit
that referenced
this pull request
Jun 4, 2023
- [ ] Regenerate this pull request now. PiperOrigin-RevId: 451250442 Source-Link: googleapis/googleapis@cca5e81 Source-Link: googleapis/googleapis-gen@0b219da Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMGIyMTlkYTE2MWE4YmRjYzNjNmY3YjJlZmNkODIxMDUxODJhMzBjYSJ9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.