Skip to content

Conversation

@calpeyser
Copy link
Contributor

Re-submission for PR #3324.

calpeyser and others added 30 commits April 26, 2017 13:34
* Vendor the GAPIC for Speech.

* Speech Partial Veneer (#3483)

* Update to docs based on @dhermes catch.

* Fix incorrect variable.

* Fix the docs.

* Style fixes to unit tests.

* More PR review from me.
* Add a __hash__ implementation to SchemaField
* Modify default list of subfields to be the empty tuple
* Making SchemaField immutable.
* Adding SchemaField.__ne__.
`assertEquals` is deprecated (but still is a synonym).
These were "broken" by the release of google-resumable-media==0.2.0,
but it just revealed that mocked response content was unicode when
it should have been `bytes`.
due to the change of the Python Client library doc link
* Using assertIs in unit tests where appropriate.

Any usage of `self.assertTrue(a is b)` has become
`self.assertIs(a, b)`.

* Converting some assertFalse(a is b) to assertIsNot(a, b).
* Fixing references to "dead" docs links.

Done via:

$ git grep -l 'google-cloud-auth.html' | \
> xargs sed -i s/'google-cloud-auth.html'/'core\/auth.html'/g
$ git grep -l 'http\:\/\/google-cloud-python.readthedocs.io' | \
> xargs sed -i s/'http\:\/\/google-cloud-python.readthedocs.io'/\
> 'https\:\/\/google-cloud-python.readthedocs.io'/g

Fixes #3531.

* Fixing up other docs that were moved in #3459.
Jon Wayne Parrott and others added 27 commits August 14, 2017 10:44
* Also add systest for user exception aborting transaction.
* Switched to google-resumable-media in BigQuery.
* Upgrading google-resumable-media dependency to 0.2.1.
* Add future interface to bigquery Jobs.
* Make QueryJob return QueryResults from result()
* Deprecate QueryJob.results()
* Removing vendored in google.cloud.streaming.

* Modifying setup.cfg so pytest errors are sane.

This is **not** to be merged, just to debug the b0rken build:
https://circleci.com/gh/GoogleCloudPlatform/google-cloud-python/2515
Include NULL values in ARRAY<INT64>.
* Removing `get_credentials()` from `core`.

In the process also:

- Slight re-org on `nox.py` config (to pass posargs) for `core`
  and `datastore`
- Getting rid of last usage of `_Monkey` in datastore

This is part of `@jonparrott`'s effort to slim down / stabilize
`core`.

* Removing `google.cloud.credentials` module from docs.
Also bumping the version on the uber-package.
* Simplifying Client constructor's for Bigtable and Spanner.

* Fixing Bigtable unit tests after Client re-factor.

Also slightly changing the Client constructor so that
it only called `with_scopes()` one time on the credentials
(was previously calling with `SCOPE=None` and then again with the
custom scope for the instance)

* Fixing Spanner unit tests after Client re-factor.

Also slightly changing the `copy()` method so that it
just passes the same credentials instance.

Also updating `nox` config to allow session `posargs`.

* Removing unused imports after Bigtable/Spanner Client re-factor.
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Aug 14, 2017
@calpeyser calpeyser closed this Aug 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: no This human has *not* signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.