Skip to content

Conversation

@calpeyser
Copy link
Contributor

Re-submission for PR #3324.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 14, 2017
@dhermes
Copy link
Contributor

dhermes commented Aug 14, 2017

@calpeyser Mind if I rebase this branch to get rid of the merge conflicts?

@dhermes
Copy link
Contributor

dhermes commented Aug 14, 2017

@calpeyser Have a look at the failing system tests:

https://circleci.com/gh/GoogleCloudPlatform/google-cloud-python/2602

@calpeyser
Copy link
Contributor Author

@dhermes for sure. Looks like it's a Python2/3 thing - I have a one line fix that I can commit against a rebase.

@dhermes
Copy link
Contributor

dhermes commented Aug 14, 2017

@calpeyser Just tried the rebase and it looks like a nontrivial collision in Table.read_rows. Can you handle the rebase?

@calpeyser calpeyser closed this Aug 14, 2017
@dhermes dhermes deleted the pr-3324-to-fix branch November 22, 2017 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants