Skip to content

Conversation

@tseaver
Copy link
Contributor

@tseaver tseaver commented Aug 12, 2017

Uses #3801 as a base.

Cherry-picked / fixed up from PR #3721.

@tseaver tseaver added the api: bigquery Issues related to the BigQuery API. label Aug 12, 2017
@tseaver tseaver requested review from dhermes and tswast August 12, 2017 21:34
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 12, 2017
@tseaver
Copy link
Contributor Author

tseaver commented Aug 12, 2017

@tswast This version returns the undeclared query parameters as instances of one of the concrete parameter classes, as you requested.

@tseaver tseaver changed the base branch from master to bigquery-b2 August 12, 2017 21:45
Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once base PR is approved.

@tseaver
Copy link
Contributor Author

tseaver commented Sep 8, 2017

Rebased after merging #3801 to the bigquery-b2 branch. I will merge when the BQ tests are green (docs build on PRs seems to hang).

@tseaver tseaver merged commit a294233 into googleapis:bigquery-b2 Sep 8, 2017
@tseaver tseaver deleted the bigquery-b2-queryjob-undeclared_query_parameters branch September 8, 2017 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants