Reuse explicit credentials when creating 'database.spanner_api'. #3722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
theacodes
reviewed
Aug 3, 2017
| """Helper for session-related API calls.""" | ||
| if self._spanner_api is None: | ||
| base_creds = self._instance._client.credentials | ||
| scoped = base_creds.with_scopes((SPANNER_DATA_SCOPE,)) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
- Preserves "custom" credentials (existing code worked only with implicit credentials from the environment). - Add tests ensuring scopes are set for correctly for all GAX apis (client uses admin scope, which do not grant data access, while database uses data scope, which does not grant admin access). Closes #3718.
tseaver
force-pushed
the
3718-spanner-propagate-client-creds-to-db
branch
from
65013ad to
de8e18c
Compare
Contributor
|
Github buried my comment, re-posting:
|
Contributor
Author
|
@jonparrott Who actually implements |
'google.auth.credentials.with_scopes_if_required' doesn't replace scopes, but only adds them if missing. Addresses: #3722 (comment).
Contributor
Author
|
@jonparrott See cf5b2df |
theacodes
approved these changes
Aug 7, 2017
landrito
pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 21, 2017
…gleapis#3722) - Preserves "custom" credentials (existing code worked only with implicit credentials from the environment). - Add tests ensuring scopes are set for correctly for all GAX apis (client uses admin scope, which do not grant data access, while database uses data scope, which does not grant admin access).
landrito
pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 22, 2017
…gleapis#3722) - Preserves "custom" credentials (existing code worked only with implicit credentials from the environment). - Add tests ensuring scopes are set for correctly for all GAX apis (client uses admin scope, which do not grant data access, while database uses data scope, which does not grant admin access).
landrito
pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 22, 2017
…gleapis#3722) - Preserves "custom" credentials (existing code worked only with implicit credentials from the environment). - Add tests ensuring scopes are set for correctly for all GAX apis (client uses admin scope, which do not grant data access, while database uses data scope, which does not grant admin access).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3718.