Add properties for new job statistics #3721
Conversation
Eases construction of a client with a new project, but the same credentials / http implementation.
tseaver
added
api: bigquery
googlebot
added
the
cla: yes
|
I'm going to defer to @tswast for this. |
tswast
left a comment
tswast
left a comment
There was a problem hiding this comment.
Thanks! A couple suggestions.
| See: | ||
| https://cloud.google.com/bigquery/docs/reference/rest/v2/jobs#statistics.query.queryPlan | ||
| :rtype: list of dict |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| return job | ||
|
|
||
| @property | ||
| def query_plan(self): |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| project=project, credentials=credentials, _http=_http) | ||
| self._connection = Connection(self) | ||
|
|
||
| def _clone(self, project): |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| t_project = table['projectId'] | ||
| t_client = clients_by_project.get(t_project) | ||
| if t_client is None: | ||
| t_client = client._clone(t_project) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| return tables | ||
|
|
||
| @property | ||
| def num_dml_affected_rows(self): |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| See: | ||
| https://cloud.google.com/bigquery/docs/reference/rest/v2/jobs#statistics.query.schema | ||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| See: | ||
| https://cloud.google.com/bigquery/docs/reference/rest/v2/jobs#statistics.query.undeclaredQueryParamters | ||
| :rtype: list of dict |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| :returns: a new instance, bound to the supplied project, using | ||
| the same credentials / http object as this instance. | ||
| """ | ||
| return self.__class__(project, self._credentials, self._http) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@tswast I'm going to break this up into separate PRs, targeting the |
5 participants
Closes #3706.
Note for reviewers: commit-by-commit might be an easier path.