Add system test of updating/deleting bucket labels. #3715
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out some properties (i.e., 'labels', see #3711) behave differently under 'patch semantics'[1], which makes 'update' useful. [1] https://cloud.google.com/storage/docs/json_api/v1/how-tos/performance#patch
Note that the test uses the new 'Bucket.update' method, rather than 'Bucket.patch', because patch semantics would require that we remember deleted labels (in order to pass 'null' as their value). Closes #7311
Show using 'bucket.update()' to avoid running into patch semantics.
googlebot
added
the
cla: yes
lukesneeringer
approved these changes
Aug 4, 2017
landrito
pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 21, 2017
…is#3715) Turns out some properties (i.e., 'labels', see googleapis#3711) behave differently under 'patch semantics'[1], which makes 'update' useful. [1] https://cloud.google.com/storage/docs/json_api/v1/how-tos/performance#patch Closes googleapis#7311
landrito
pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 22, 2017
…is#3715) Turns out some properties (i.e., 'labels', see googleapis#3711) behave differently under 'patch semantics'[1], which makes 'update' useful. [1] https://cloud.google.com/storage/docs/json_api/v1/how-tos/performance#patch Closes googleapis#7311
landrito
pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 22, 2017
…is#3715) Turns out some properties (i.e., 'labels', see googleapis#3711) behave differently under 'patch semantics'[1], which makes 'update' useful. [1] https://cloud.google.com/storage/docs/json_api/v1/how-tos/performance#patch Closes googleapis#7311
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses #3714 as a base.
Note that the test uses the new
Bucket.updatemethod, rather thanBucket.patch, because patch semantics might require that we remember deleted labels (in order to passnullas their value).Closes #3711