Fix pylint for the main package #3658

theacodes · 2017-07-24T16:42:37Z

NOTE: Pylint is still failing against tests, I have a longer-term strategy to address this which I'll propose later.

This reverts commit 768d667.

core/google/cloud/_http.py

-        :raises: Exception if the response code is not 200 OK.
+        :raises ~google.cloud.exceptions.GoogleCloudError: if the response code
+            is not 200 OK.
+        :raises TypeError: if the response content type is not JSON.


core/google/cloud/_testing.py


 class _Monkey(object):
-    # context-manager for replacing module names in the scope of a test.
+    """Context-manager for replacing module names in the scope of a test."""


core/google/cloud/_testing.py



+# pylint: disable=invalid-name
+# Retain _tempdir as a constant for backwards compatibility despite


core/google/cloud/client.py

        :returns: The client created with the retrieved JSON credentials.
-        :raises: :class:`TypeError` if there is a conflict with the kwargs
+        :raises TypeError: if there is a conflict with the kwargs
                 and the credentials created by the factory.


core/google/cloud/iterator.py


-        Yields :class:`Page` instances.
+        :rtype: :class:`Page`
+        :returns: pages


Fix pylint for the main package

56092e2

This reverts commit 768d667.

theacodes added the DevEx label Jul 24, 2017

theacodes requested review from dhermes and lukesneeringer July 24, 2017 16:42

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 24, 2017

dhermes approved these changes Jul 24, 2017

View reviewed changes

theacodes merged commit 506a304 into googleapis:master Jul 24, 2017

theacodes deleted the fix-core-lint branch July 24, 2017 21:09

dhermes mentioned this pull request Aug 4, 2017

Cutting release google-cloud-core==0.26.0. #3727

Merged

landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 21, 2017

Fix pylint for the main package (googleapis#3658)

52aac47

landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017

Fix pylint for the main package (googleapis#3658)

54ee13b

landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017

Fix pylint for the main package (googleapis#3658)

0a014eb

parthea pushed a commit that referenced this pull request Nov 24, 2025

Fix pylint for the main package (#3658)

0a28565



		# pylint: disable=invalid-name
		# Retain _tempdir as a constant for backwards compatibility despite

Fix pylint for the main package #3658

Fix pylint for the main package #3658

Uh oh!

Conversation

theacodes commented Jul 24, 2017

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants