Skip to content

Patch in the version updates made when fixing #3579. #3591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dhermes merged 1 commit into from
Jul 11, 2017
Merged

Patch in the version updates made when fixing #3579. #3591

dhermes merged 1 commit into from
Jul 11, 2017

Conversation

@dhermes
Copy link
Contributor

@dhermes dhermes commented Jul 6, 2017

Changes from #3586 and #3588.

@dhermes dhermes added api: datastore Issues related to the Datastore API. api: clouderrorreporting Issues related to the Error Reporting API. api: logging Issues related to the Cloud Logging API. api: storage Issues related to the Cloud Storage API. packaging labels Jul 6, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 6, 2017
tseaver
tseaver reviewed Jul 6, 2017
View reviewed changes
error_reporting/setup.py
REQUIREMENTS = [
'google-cloud-core >= 0.25.0, < 0.26dev',
'google-cloud-logging >= 1.0.0, < 2.0dev',
'google-cloud-logging >= 1.1.0, < 1.2dev',

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

setup.py
'google-cloud-spanner >= 0.25.0, < 0.26dev',
'google-cloud-speech >= 0.26.0, < 0.27dev',
'google-cloud-storage >= 1.2.0, < 2.0dev',
'google-cloud-storage >= 1.2.0, < 1.3dev',

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermes
Copy link
Contributor Author

dhermes commented Jul 6, 2017

@tseaver I recommend reading #3579 for the "why" here.

The issue isn't API compatibility across versions, it is dependency compatibility.

@dhermes dhermes merged commit 569e739 into googleapis:master Jul 11, 2017
@dhermes dhermes deleted the upstream-3579-changes branch July 11, 2017 20:28
@dhermes
Copy link
Contributor Author

dhermes commented Jul 11, 2017

Merged based on @lukesneeringer assertion.

@tseaver would you like to take the lead on deciding "what now" about these versioning issues with google-cloud-core?

landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 21, 2017
@dhermes @landrito
Patch in the version updates made when fixing googleapis#3579. (googl…
1c4f3c1 
…eapis#3591)
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
@dhermes @landrito
Patch in the version updates made when fixing googleapis#3579. (googl…
4b4918a 
…eapis#3591)
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
@dhermes @landrito
Patch in the version updates made when fixing googleapis#3579. (googl…
2db88f1 
…eapis#3591)
parthea pushed a commit that referenced this pull request Nov 24, 2025
@dhermes
Patch in the version updates made when fixing #3579. (#3591)
c27981c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@lukesneeringer lukesneeringer lukesneeringer left review comments

@tseaver tseaver tseaver left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@lukesneeringer lukesneeringer

@tseaver tseaver

@theacodes theacodes

Labels

api: clouderrorreporting Issues related to the Error Reporting API. api: datastore Issues related to the Datastore API. api: logging Issues related to the Cloud Logging API. api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement. packaging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dhermes @lukesneeringer @tseaver @theacodes @googlebot