added support for creating a view with useLegacySql = False#3514
Merged
Conversation
googlebot
added
the
cla: yes
tseaver
reviewed
Jun 21, 2017
tseaver
left a comment
tseaver
left a comment
Contributor
There was a problem hiding this comment.
LGTM except for the commented out lines noted inline.
| RESOURCE['expirationTime'] = _millis(self.EXP_TIME) | ||
| RESOURCE['view'] = {} | ||
| RESOURCE['view']['query'] = QUERY | ||
| # RESOURCE['view']['useLegacySql'] = True |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Oops… I forgot to remove those after verifying the other changes worked. Removed…
Author
|
My mistake. These commented out lines are now fully removed. |
Contributor
|
@richkadel Thank you very much for the patch! |
tseaver
added
the
type: feature request
tseaver
pushed a commit
that referenced
this pull request
Jul 10, 2017
landrito
pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 21, 2017
landrito
pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 22, 2017
landrito
pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 22, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plus a couple of small doc fixes.
Passes tests and coverage.
Closes #3388.