Skip to content

Using binary streams for uploads in BigQuery system tests. #3374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dhermes merged 1 commit into from
May 5, 2017
Merged

Using binary streams for uploads in BigQuery system tests. #3374

dhermes merged 1 commit into from
May 5, 2017

Conversation

@dhermes
Copy link
Contributor

@dhermes dhermes commented May 4, 2017

Fixes #3371.

@dhermes dhermes added api: bigquery Issues related to the BigQuery API. build labels May 4, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 4, 2017
@dhermes dhermes added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. and removed cla: yes This human has signed the Contributor License Agreement. labels May 4, 2017
@dhermes
Copy link
Contributor Author

dhermes commented May 4, 2017

CI failed because the logging build stalled out (a hard-to-repro issue we have yet to track down).

@lukesneeringer Why would logging even be running here?

Are we good to merge? (Note this branch is on the https://github.com/GoogleCloudPlatform/google-cloud-python/ remote, so the system tests have already run and passed for BigQuery.)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 4, 2017
@dhermes dhermes merged commit 9870057 into master May 5, 2017
@dhermes dhermes deleted the fix-3371 branch May 5, 2017 22:42
@tseaver tseaver mentioned this pull request Jun 26, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@theacodes theacodes theacodes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@lukesneeringer lukesneeringer

@tseaver tseaver

Labels

api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dhermes @theacodes @lukesneeringer @tseaver @googlebot