Skip to content

Dropping internal usage of rewind in Blob.upload_from_string(). #3365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dhermes merged 1 commit into from
May 4, 2017
Merged

Dropping internal usage of rewind in Blob.upload_from_string(). #3365

dhermes merged 1 commit into from
May 4, 2017

Conversation

@dhermes
Copy link
Contributor

@dhermes dhermes commented May 3, 2017

No description provided.

@dhermes dhermes added the api: storage Issues related to the Cloud Storage API. label May 3, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 3, 2017
@dhermes
Copy link
Contributor Author

dhermes commented May 4, 2017

I'm going to hold off on this merge since it will have a conflict with #3362.

@dhermes dhermes added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 4, 2017
@dhermes dhermes mentioned this pull request May 4, 2017
Merged
@dhermes dhermes merged commit 520637c into googleapis:master May 4, 2017
@dhermes dhermes deleted the no-more-rewind-upload_from_string branch May 4, 2017 17:48
This was referenced Jun 26, 2017
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@theacodes theacodes theacodes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@lukesneeringer lukesneeringer

@tseaver tseaver

Labels

api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dhermes @theacodes @lukesneeringer @tseaver @googlebot