Skip to content

Cut release 1.0.0 of logging package. #3278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lukesneeringer merged 2 commits into from
Apr 7, 2017
Merged

Cut release 1.0.0 of logging package. #3278

lukesneeringer merged 2 commits into from
Apr 7, 2017

Conversation

@dhermes
Copy link
Contributor

@dhermes dhermes commented Apr 6, 2017

Should be OK after #3270? I made this branch on the GoogleCloudPlatform remote so that system tests are run in this PR.

@dhermes dhermes added api: logging Issues related to the Cloud Logging API. packaging labels Apr 6, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 6, 2017
@dhermes
Copy link
Contributor Author

dhermes commented Apr 6, 2017

Error on Windows: https://ci.appveyor.com/project/GoogleCloudPlatform/google-cloud-python/build/1.0.1430.master/job/ru59q79vnb23wxiu

any_pb == any_pb

will fail if the type is unregistered. This seems like a big FAIL of google.protobuf.

@lukesneeringer
Copy link
Contributor

lukesneeringer commented Apr 7, 2017

Why on earth would that __eq__ not work only on Windows?

@lukesneeringer lukesneeringer merged commit 7cf9051 into master Apr 7, 2017
@lukesneeringer lukesneeringer deleted the cut-logging-1.0.0 branch April 7, 2017 01:43
@dhermes
Copy link
Contributor Author

dhermes commented Apr 19, 2017

Looks like error-reporting==0.24.1 never got pushed. Will push a tag right now at 5878b78.

Only changes are this and #3299:

$ git log error-reporting-0.24.0..error-reporting-0.24.1 -- error_reporting/
commit 138f59fc1795e1e433822bdd62d927762fd8f2e2
Author: Bill Prin <waprin@gmail.com>
Date:   Mon Apr 17 10:16:11 2017 -0700

    Replace httpContext with httpRequest (#3299)

commit 7cf905115fbfa9d54850b6a3426f38ab7096009e
Author: Danny Hermes <daniel.j.hermes@gmail.com>
Date:   Thu Apr 6 18:43:55 2017 -0700

    Cut release 1.0.0 of logging package. (#3278)

richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
@dhermes @lukesneeringer
Cut release 1.0.0 of logging package. (googleapis#3278)
772db29
parthea pushed a commit that referenced this pull request Nov 24, 2025
@dhermes @lukesneeringer
Cut release 1.0.0 of logging package. (#3278)
d77eec8
parthea pushed a commit that referenced this pull request Nov 24, 2025
@dhermes @lukesneeringer
Cut release 1.0.0 of logging package. (#3278)
d65e970
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@lukesneeringer lukesneeringer

@tseaver tseaver

Labels

api: logging Issues related to the Cloud Logging API. cla: yes This human has signed the Contributor License Agreement. packaging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dhermes @lukesneeringer @tseaver @googlebot