-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Vision Beta #3104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vision Beta #3104
Conversation
|
In this, there's mention of changing I looked and I didn't see anything about "alpha" in the docs so I think those are set. |
| setup( | ||
| name='google-cloud-vision', | ||
| version='0.23.2', | ||
| version='0.23.3', |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@dhermes I just remembered I forgot to bring this up at the standup. On the GAPIC side, we bump versions to 0.90 when they hit beta. However: (1) We did not do that for other libraries here, and The beta designation here entails an expectation change, but not so much an actually significant code change. I am willing to bump to 0.24.0 in principle but it would entail bumping everything (which is kind of time consuming). Also fine with just bumping to 0.23.3, and what we changed is "hey, beta status". Thoughts? |
|
As a note, when we go GA, we will need to bump the version of the GA libraries to 1.x |
|
@lukesneeringer That expectation works for me. Also, keep in mind we can do an umbrella release without "bumping everything": simple change the API at hand and rev the version (we don't need 23<-->23 to match) |
|
Concur, although I think the consistency is valuable in the immediate term. I am also hoping So, am I good to merge this? |
|
Sure thing |
|
Merged. @daspecster Please cut a release and remember to manually bump docs so we see the beta designation on the index page. |
|
@lukesneeringer nothing was changed in the "docs", just the README here just FYI. |
This PR officially makes
google-cloud-visiona beta library.@daspecster What else (besides a release, of course) is needed to accomplish this? Do the docs proclaim Vision as alpha right now? If so, we need to update that. (Also, we will need a manual docs trigger once this is pushed out.)