Skip to content

Conversation

@lukesneeringer
Copy link
Contributor

This PR officially makes google-cloud-vision a beta library.

@daspecster What else (besides a release, of course) is needed to accomplish this? Do the docs proclaim Vision as alpha right now? If so, we need to update that. (Also, we will need a manual docs trigger once this is pushed out.)

@lukesneeringer lukesneeringer self-assigned this Mar 6, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 6, 2017
@daspecster
Copy link
Contributor

daspecster commented Mar 6, 2017

In this, there's mention of changing Landmark to FacialFeature. I think that might be good to do before beta. WDYT?

I looked and I didn't see anything about "alpha" in the docs so I think those are set.

setup(
name='google-cloud-vision',
version='0.23.2',
version='0.23.3',

This comment was marked as spam.

This comment was marked as spam.

@lukesneeringer
Copy link
Contributor Author

@dhermes I just remembered I forgot to bring this up at the standup.

On the GAPIC side, we bump versions to 0.90 when they hit beta. However:

(1) We did not do that for other libraries here, and
(2) That would be inconsistent with how we track everything to core 0.23.x

The beta designation here entails an expectation change, but not so much an actually significant code change. I am willing to bump to 0.24.0 in principle but it would entail bumping everything (which is kind of time consuming). Also fine with just bumping to 0.23.3, and what we changed is "hey, beta status".

Thoughts?

@lukesneeringer
Copy link
Contributor Author

As a note, when we go GA, we will need to bump the version of the GA libraries to 1.x

@dhermes
Copy link
Contributor

dhermes commented Mar 6, 2017

@lukesneeringer That expectation works for me. Also, keep in mind we can do an umbrella release without "bumping everything": simple change the API at hand and rev the version (we don't need 23<-->23 to match)

@lukesneeringer
Copy link
Contributor Author

Concur, although I think the consistency is valuable in the immediate term. I am also hoping google-cloud-core is much more stable now than it was a couple months ago.

So, am I good to merge this?

@dhermes
Copy link
Contributor

dhermes commented Mar 6, 2017

Sure thing

@lukesneeringer lukesneeringer merged commit 5cbfc43 into googleapis:master Mar 6, 2017
@lukesneeringer
Copy link
Contributor Author

Merged. @daspecster Please cut a release and remember to manually bump docs so we see the beta designation on the index page.

@daspecster
Copy link
Contributor

@lukesneeringer nothing was changed in the "docs", just the README here just FYI.

@daspecster
Copy link
Contributor

richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
parthea pushed a commit that referenced this pull request Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants