Bump logging dependencies to 0.91.0 #3079
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
daspecster
approved these changes
Feb 27, 2017
Contributor
daspecster
left a comment
daspecster
left a comment
There was a problem hiding this comment.
LGTM pending Travis/Circle.
Contributor
Author
|
This almost certainly is not okay as is -- the logging unit tests skipped tons of tests. Looking into it. |
Contributor
Author
|
I did not realize that I had not migrated this from |
Contributor
|
@lukesneeringer which tests were skipped? |
dhermes
reviewed
Feb 27, 2017
|
|
||
| setup( | ||
| name='google-cloud-logging', | ||
| version='0.23.0', |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
Author
All the ones depending on GAX. I fixed it. |
richkadel
pushed a commit
to richkadel/google-cloud-python
that referenced
this pull request
May 6, 2017
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3078.