Skip to content

Speech Client Library Header#3048

Merged
lukesneeringer merged 7 commits intogoogleapis:masterfrom
lukesneeringer:speech-gccl
Feb 22, 2017
Merged

Speech Client Library Header#3048
lukesneeringer merged 7 commits intogoogleapis:masterfrom
lukesneeringer:speech-gccl

Conversation

@lukesneeringer
Copy link
Contributor

@lukesneeringer lukesneeringer commented Feb 22, 2017

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 22, 2017
@lukesneeringer lukesneeringer added the api: speech Issues related to the Speech-to-Text API. label Feb 22, 2017
@lukesneeringer lukesneeringer mentioned this pull request Feb 22, 2017
Closed
7 tasks
@googlebot
Copy link

googlebot commented Feb 22, 2017

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Feb 22, 2017
dhermes
dhermes approved these changes Feb 22, 2017
View reviewed changes
speech/google/cloud/speech/_gax.py
DEFAULT_USER_AGENT,
operations_grpc.OperationsStub,
OPERATIONS_API_HOST)
OPERATIONS_API_HOST,

This comment was marked as spam.

Sign in to view

speech/setup.py
setup(
name='google-cloud-speech',
version='0.22.0',
version='0.23.0',

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

speech/unit_tests/test_client.py
def speech_api(channel=None, **kwargs):
return _MockGAPICSpeechAPI(response=_make_sync_response(),
channel=channel)
channel=channel, **kwargs)

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@lukesneeringer lukesneeringer added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Feb 22, 2017
@lukesneeringer lukesneeringer merged commit 2c608f9 into googleapis:master Feb 22, 2017
@lukesneeringer lukesneeringer deleted the speech-gccl branch February 22, 2017 17:22
@daspecster daspecster mentioned this pull request Feb 24, 2017
Merged
19 tasks
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
@lukesneeringer
Speech Client Library Header (googleapis#3048)
9380701
atulep pushed a commit that referenced this pull request Apr 3, 2023
@lukesneeringer
Speech Client Library Header (#3048)
685269e
atulep pushed a commit that referenced this pull request Apr 18, 2023
@lukesneeringer
Speech Client Library Header (#3048)
89e2e9a
parthea pushed a commit that referenced this pull request Oct 22, 2023
@lukesneeringer
Speech Client Library Header (#3048)
4af337c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@tseaver tseaver tseaver left review comments

@dhermes dhermes dhermes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@lukesneeringer lukesneeringer

Labels

api: speech Issues related to the Speech-to-Text API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lukesneeringer @googlebot @tseaver @dhermes @bjwatson