Update core dependency to google-cloud-core >= 0.23.0, < 0.24dev. #3028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
3 tasks
dhermes
approved these changes
Feb 15, 2017
Contributor
dhermes
left a comment
dhermes
left a comment
There was a problem hiding this comment.
LGTM, though this might be premature
Contributor
Author
|
Premature? This can wait if needed. |
Contributor
lukesneeringer
left a comment
lukesneeringer
left a comment
There was a problem hiding this comment.
Have you verified that all of the Client subclasses are sending the right arguments to super?
vision/setup.py
Outdated
| REQUIREMENTS = [ | ||
| 'enum34', | ||
| 'google-cloud-core >= 0.22.1, < 0.23dev', | ||
| 'google-cloud-core >= 0.23., < 0.24dev', |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
Author
|
@lukesneeringer I haven't checked the clients. I feel like that should be a separate PR? |
Contributor
|
@dhermes said (in an instant message) that it is already done. |
Contributor
|
@dhermes Why is merging this premature? It seems reasonable to me. |
Contributor
|
Feel free to merge. No worries. |
19 tasks
richkadel
pushed a commit
to richkadel/google-cloud-python
that referenced
this pull request
May 6, 2017
…ogleapis#3028) * Update core dependency to google-cloud-core >= 0.23.0, < 0.24dev.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates 'google-cloud-core >= 0.23.0, < 0.24dev' dependencies in services.