Only using explicit namespace when deserializing key pb.#292
Merged
tseaver merged 2 commits intogoogleapis:masterfrom Oct 27, 2014
Merged
Only using explicit namespace when deserializing key pb.#292tseaver merged 2 commits intogoogleapis:masterfrom
tseaver merged 2 commits intogoogleapis:masterfrom
Conversation
This issue surfaced during review for googleapis#282.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This is to ensure that values are correctly ignored when the field isn't set on the protobuf.
Contributor
Author
|
Tests updated. PTAL. |
tseaver
added a commit
that referenced
this pull request
Oct 27, 2014
Only using explicit namespace when deserializing key pb.
parthea
pushed a commit
that referenced
this pull request
Jun 4, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Victor Chudnovsky <vchudnov@google.com>
parthea
pushed a commit
that referenced
this pull request
Jun 4, 2023
parthea
pushed a commit
that referenced
this pull request
Jun 4, 2023
Source-Link: googleapis/synthtool@fdba3ed Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:1f0dbd02745fb7cf255563dab5968345989308544e52b7f460deadd5e78e63b0
parthea
pushed a commit
that referenced
this pull request
Jun 4, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea
added a commit
that referenced
this pull request
Jun 4, 2023
* fix(deps): Require google-api-core >=1.34.0, >=2.11.0 fix: Drop usage of pkg_resources fix: Fix timeout default values docs(samples): Snippetgen should call await on the operation coroutine before calling result PiperOrigin-RevId: 493260409 Source-Link: googleapis/googleapis@fea4387 Source-Link: googleapis/googleapis-gen@387b734 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMzg3YjczNDRjNzUyOWVlNDRiZTg0ZTYxM2IxOWE4MjA1MDhjNjEyYiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * add gapic_version.py Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea
pushed a commit
that referenced
this pull request
Jun 4, 2023
Source-Link: googleapis/synthtool@50db768 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e09366bdf0fd9c8976592988390b24d53583dd9f002d476934da43725adbb978
parthea
pushed a commit
that referenced
this pull request
Jun 4, 2023
Source-Link: googleapis/synthtool@1b71c10 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:00c9d764fd1cd56265f12a5ef4b99a0c9e87cf261018099141e2ca5158890416 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea
pushed a commit
that referenced
this pull request
Aug 15, 2023
…292) Source-Link: https://togithub.com/googleapis/synthtool/commit/395d53adeeacfca00b73abf197f65f3c17c8f1e9 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:6c1cbc75c74b8bdd71dada2fa1677e9d6d78a889e9a70ee75b93d1d0543f96e1
parthea
added a commit
that referenced
this pull request
Sep 20, 2023
…rors. (#292) Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea
pushed a commit
that referenced
this pull request
Sep 20, 2023
#292) * feat(Transcoder): update captions code samples for display name and language * test bucket should be deleted * Trigger Build
vchudnov-g
pushed a commit
that referenced
this pull request
Sep 20, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea
pushed a commit
that referenced
this pull request
Sep 22, 2023
Source-Link: googleapis/synthtool@ca87909 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:6162c384d685c5fe22521d3f37f6fc732bf99a085f6d47b677dbcae97fc21392
parthea
added a commit
that referenced
this pull request
Sep 22, 2023
fix(deps): require proto-plus >= 1.22.0
parthea
pushed a commit
that referenced
this pull request
Sep 22, 2023
- [ ] Regenerate this pull request now. PiperOrigin-RevId: 472561635 Source-Link: googleapis/googleapis@332ecf5 Source-Link: googleapis/googleapis-gen@4313d68 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDMxM2Q2ODI4ODBmZDlkNzI0NzI5MTE2NGQ0ZTlkM2Q1YmQ5ZjE3NyJ9
parthea
added a commit
that referenced
this pull request
Sep 22, 2023
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea
pushed a commit
that referenced
this pull request
Sep 22, 2023
Source-Link: googleapis/synthtool@c5026b3 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:0e18b9475fbeb12d9ad4302283171edebb6baf2dfca1bd215ee3b34ed79d95d7 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea
pushed a commit
that referenced
this pull request
Sep 22, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea
pushed a commit
that referenced
this pull request
Sep 22, 2023
…[autoapprove] (#292) Source-Link: googleapis/synthtool@1f37ce7 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:8e84e0e0d71a0d681668461bba02c9e1394c785f31a10ae3470660235b673086
parthea
pushed a commit
that referenced
this pull request
Sep 22, 2023
- [ ] Regenerate this pull request now. PiperOrigin-RevId: 451250442 Source-Link: googleapis/googleapis@cca5e81 Source-Link: googleapis/googleapis-gen@0b219da Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMGIyMTlkYTE2MWE4YmRjYzNjNmY3YjJlZmNkODIxMDUxODJhMzBjYSJ9
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
parthea
added a commit
that referenced
this pull request
Oct 21, 2023
Test the minimum supported dependencies in python 3.7 unit tests to prepare for dropping python 3.6
parthea
added a commit
that referenced
this pull request
Oct 21, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
fix: Add dict typing for client_options chore: update to gapic-generator-python 1.5.0 chore: use autogenerated setup.py - [ ] Regenerate this pull request now. PiperOrigin-RevId: 484665853 Source-Link: https://togithub.com/googleapis/googleapis/commit/8eb249a19db926c2fbc4ecf1dc09c0e521a88b22 Source-Link: https://togithub.com/googleapis/googleapis-gen/commit/c8aa327b5f478865fc3fd91e3c2768e54e26ad44 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYzhhYTMyN2I1ZjQ3ODg2NWZjM2ZkOTFlM2MyNzY4ZTU0ZTI2YWQ0NCJ9
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
- [ ] Regenerate this pull request now. PiperOrigin-RevId: 451250442 Source-Link: googleapis/googleapis@cca5e81 Source-Link: googleapis/googleapis-gen@0b219da Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMGIyMTlkYTE2MWE4YmRjYzNjNmY3YjJlZmNkODIxMDUxODJhMzBjYSJ9
parthea
pushed a commit
that referenced
this pull request
Oct 22, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea
pushed a commit
that referenced
this pull request
Aug 21, 2025
parthea
pushed a commit
that referenced
this pull request
Sep 16, 2025
parthea
pushed a commit
that referenced
this pull request
Sep 18, 2025
* add progress bar * update changelog * default to use the progress bar
parthea
pushed a commit
that referenced
this pull request
Nov 22, 2025
* chore: prevent normalization of semver versioning * chore: update workaround to make sic work
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
Source-Link: googleapis/synthtool@bef813d Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:94bb690db96e6242b2567a4860a94d48fa48696d092e51b0884a1a2c0a79a407 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
🤖 I have created a release *beep* *boop* --- ## [1.20.0](googleapis/proto-plus-python@v1.19.9...v1.20.0) (2022-02-07) ### Features * add custom __dir__ for messages and message classes ([#289](googleapis/proto-plus-python#289)) ([35e019e](googleapis/proto-plus-python@35e019e)) ### Bug Fixes * workaround for buggy pytest ([#291](googleapis/proto-plus-python#291)) ([28aa3b2](googleapis/proto-plus-python@28aa3b2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
FBO checkers which need to verify default values for 'retry' / 'timeout'
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
🤖 I have created a release \*beep\* \*boop\* --- ### [2.2.2](https://www.github.com/googleapis/python-api-core/compare/v2.2.1...v2.2.2) (2021-11-02) ### Bug Fixes * make 'gapic_v1.method.DEFAULT' a typed object ([#292](https://www.github.com/googleapis/python-api-core/issues/292)) ([ffc51f0](https://www.github.com/googleapis/python-api-core/commit/ffc51f03c7ce5d9f009ba859b8df385d52925578)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
Co-authored-by: Jim Fulton <jim@jimfulton.info>
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
) Source-Link: googleapis/synthtool@7804ade Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:eede5672562a32821444a8e803fb984a6f61f2237ea3de229d2de24453f4ae7d
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
* chore: Adds python eol deprecation warning * add warnings module * includes sys_micro
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
In an overabundance of caution, we were deleting `cursor_after` from QueryIterator after exhausting the iterator. This was found to differ from the original implementation, however, and break some customer's code. Fixes #292
parthea
pushed a commit
that referenced
this pull request
Nov 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This issue surfaced during review for #282.