Converting remaining datastore snippets to doctests #2831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the process, adding a Config.TO_DELETE runtime list so that test cleanup can handle any loose objects created.
googlebot
added
the
cla: yes
Contributor
|
I like it! |
theacodes
approved these changes
Dec 8, 2016
Contributor
Author
|
Blerg! Python 2 and 3 strike again: Proposed short-term "fix": Only run snippet tests in Python 2? @jonparrott and @tseaver any better ideas? |
Contributor
|
@dhermes I hate any testing dependency on repr, period (and tracebacks even worse). |
Contributor
Author
|
@tseaver Yes I'm aware of your strong opinion. Any |
Contributor
|
@dhermes Either change the example not to use the repr, or change the repr not to use the "dict literal" repr of the keys / values. |
richkadel
pushed a commit
to richkadel/google-cloud-python
that referenced
this pull request
May 6, 2017
Converting remaining datastore snippets to doctests
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
Converting remaining datastore snippets to doctests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's worth noting that I delegated clean-up to
system_tests/datastore.py::tearDownModule. This is because (in my experimenting) I discovered that thesphinx.ext.doctestdirectivetestcleanupdoesn't run when the thing being tested fails. (FWIW, I think it'd be fairly easy for one of us to send a PR to the Sphinx project and fix that behavior, but that was outside the scope of this PR.)To make dev a little faster I did the following:
and every time I made a change I just re-installed into the env
Might be worth turning this into a script someday? But I don't want to design it before we know how we'll use it. Just putting it here for posterity.
There is a
code-blocksnippet indatastore._httpbut that module is non-public so I left it alone.This package could use some more snippets, but for now at least they are all covered.