Skip to content

Conversation

@dhermes
Copy link
Contributor

@dhermes dhermes commented Dec 6, 2016

@dhermes dhermes added auth api: translation Issues related to the Cloud Translation API API. labels Dec 6, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 6, 2016
Copy link
Contributor

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay!

@dhermes dhermes merged commit 5f68b4a into googleapis:master Dec 6, 2016
@dhermes dhermes deleted the fix-2734 branch December 6, 2016 18:09
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
Removing support for API_KEY auth in translate.
@lukesneeringer
Copy link
Contributor

lukesneeringer commented Jul 28, 2017

Hey folks -- what was the reason why we did this? I went down the rabbit hole and I can see that everyone agreed it was a good idea, but nowhere can I find an explanation as to why.

Cards on table: I had a "bug" filed on this recently (internal folks: b/64123162), and so I need to grok what the appropriate answer is (e.g. whether to put this support back, or say that we are not going to do it because ______).

@daspecster
Copy link
Contributor

@lukesneeringer, as I recall, it was mostly because the API key auth was outside of the normal authentication methods and I believe it was said that API key based auth was going away..or they(backend) were trying to not support it in the future.

@tseaver
Copy link
Contributor

tseaver commented Jul 28, 2017

@lukesneeringer the description @daspecster gave matches my memory. Sort of an extension of "Special cases aren't special enough to break the rules."

@theacodes
Copy link
Contributor

API keys are strongly being discouraged for Cloud APIs, especially for client libraries targeting backend languages. Omar has more details. :)

@lukesneeringer
Copy link
Contributor

Thanks. :-)

parthea pushed a commit that referenced this pull request Oct 21, 2023
Removing support for API_KEY auth in translate.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: translation Issues related to the Cloud Translation API API. auth cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants