Skip to content

Upgrading GAPIC deps to 0.14 series. #2795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dhermes merged 1 commit into from
Dec 3, 2016
Merged

Upgrading GAPIC deps to 0.14 series. #2795

dhermes merged 1 commit into from
Dec 3, 2016

Conversation

@dhermes
Copy link
Contributor

@dhermes dhermes commented Dec 2, 2016

In the process, ditching hard deps on protobufs, grpcio, and google-gax in those packages. Also had
to upgrade calls to list_log_entries() based on: https://github.com/googleapis/api-client-staging/pull/118/files/2bcd2875a578ae525d2aabb862cf9c131b4665f5#r90422054

/cc @geigerj @bjwatson

@waprin I could not for the life of me figure out how to use resource_names instead of the deprecated project_ids. Can you explain? (Trying foo --> project/foo did not work)

@dhermes
Upgrading GAPIC deps to 0.14 series.
dc10367 
In the process, ditching **hard** deps on protobufs,
grpcio, and google-gax in those packages. Also had
to upgrade calls to list_log_entries() based on

https://github.com/googleapis/api-client-staging/pull/118/files/2bcd2875a578ae525d2aabb862cf9c131b4665f5#r90422054
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 2, 2016
@tseaver
Copy link
Contributor

tseaver commented Dec 2, 2016

@dhermes Should we work out what the story is supposed to be for resource_names before merging?

@dhermes
Copy link
Contributor Author

dhermes commented Dec 2, 2016

@tseaver The system tests are still passing, so I don't think it's necessary to block on that, though we should get it straightened out. (Was there a version bump for this API I wasn't aware of that deprecated the field?)

@waprin
Copy link
Contributor

waprin commented Dec 2, 2016

@dhermes did you try foo -> projects/foo ? (note the plural projects). Apologies if you just had a typo in your original message, but I do hope that was the problem since it's an easy fix :)

@dhermes
Copy link
Contributor Author

dhermes commented Dec 2, 2016

This is what I did before (I know because my chat log with @geigerj)

resource_names = ['project/' + project for project in projects]

@waprin Should we allow callers to send other resource types? I checked and only project IDs come through in the system tests.

@geigerj
Copy link
Contributor

geigerj commented Dec 2, 2016

@dhermes project/ -> projects/?

@dhermes
Copy link
Contributor Author

dhermes commented Dec 2, 2016

@geigerj Right that's what @waprin just said (and I confirmed I was holding the gun wrong before)

@waprin
Copy link
Contributor

waprin commented Dec 2, 2016

Docs look like there are some "orgazinations/" thing but I'm not familiar with it tbh, will have to ask around.

@dhermes
Copy link
Contributor Author

dhermes commented Dec 2, 2016

@tseaver Let's merge this and continue this discussion elsewhere (like a PR which converts projects to resource_names)

@tseaver
Copy link
Contributor

tseaver commented Dec 3, 2016

LGTM

@dhermes dhermes merged commit 7c73b58 into googleapis:master Dec 3, 2016
@dhermes dhermes deleted the update-gapic-0.14 branch December 3, 2016 00:03
This was referenced Dec 9, 2016
Merged
Closed
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
@dhermes
Merge pull request googleapis#2795 from dhermes/update-gapic-0.14
98948b2 
Upgrading GAPIC deps to 0.14 series.
atulep pushed a commit that referenced this pull request Apr 3, 2023
@dhermes
Merge pull request #2795 from dhermes/update-gapic-0.14
95587a9 
Upgrading GAPIC deps to 0.14 series.
atulep pushed a commit that referenced this pull request Apr 18, 2023
@dhermes
Merge pull request #2795 from dhermes/update-gapic-0.14
91aedb6 
Upgrading GAPIC deps to 0.14 series.
parthea pushed a commit that referenced this pull request Oct 22, 2023
@dhermes
Merge pull request #2795 from dhermes/update-gapic-0.14
ddd1758 
Upgrading GAPIC deps to 0.14 series.
parthea pushed a commit that referenced this pull request Nov 24, 2025
@dhermes
Merge pull request #2795 from dhermes/update-gapic-0.14
40aa2ed 
Upgrading GAPIC deps to 0.14 series.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@tseaver tseaver

Labels

cla: yes This human has signed the Contributor License Agreement. grpc

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@dhermes @tseaver @waprin @geigerj @daspecster @googlebot