Skip to content

Fix double encoding of messages when commit() fails. #2773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
daspecster merged 1 commit into from
Nov 29, 2016
Merged

Fix double encoding of messages when commit() fails. #2773

daspecster merged 1 commit into from
Nov 29, 2016

Conversation

@daspecster
Copy link
Contributor

@daspecster daspecster commented Nov 28, 2016

Fixes #2771

This copies the messages variable instead of transforming it in place so that if a commit() fails, the messages aren't double encoded.

@daspecster daspecster added the api: pubsub Issues related to the Pub/Sub API. label Nov 28, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 28, 2016
dhermes
dhermes reviewed Nov 28, 2016
View reviewed changes
pubsub/google/cloud/pubsub/_http.py
:returns: list of opaque IDs for published messages.
"""
_transform_messages_base64(messages, _base64_unicode)
messages_to_send = copy.deepcopy(messages)

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@daspecster daspecster mentioned this pull request Nov 28, 2016
Closed
@daspecster daspecster merged commit c40e0d4 into googleapis:master Nov 29, 2016
@daspecster daspecster deleted the support-multiple-commits-if-failed-2771 branch November 29, 2016 03:26
@dhermes dhermes mentioned this pull request Dec 9, 2016
Merged
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
@daspecster
Merge pull request googleapis#2773 from daspecster/support-multiple-c…
60fed0a 
…ommits-if-failed-2771

Fix double encoding of messages when commit() fails.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@dhermes dhermes dhermes left review comments

@HakShak HakShak HakShak left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@tseaver tseaver

Labels

api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@daspecster @dhermes @HakShak @tseaver @googlebot