Add Flask Helper to Error Reporting #2751

waprin · 2016-11-17T22:40:03Z

daspecster · 2016-11-18T04:26:12Z

@waprin was this ready for review? I know there are no assignees, but there's also no "Don't merge" label.

docs/error-reporting-usage.rst

+    >>>     client = error_reporting.Client()
+    >>>     client.report_exception(
+    >>>         http_context=build_flask_context(request))
+    >>>     # rest of error response code here


docs/error-reporting-usage.rst

+
+ .. code-block:: python
+
+    >>> @app.errorhandler(Exception)


docs/error-reporting-usage.rst

+ .. code-block:: python
+
+    >>> @app.errorhandler(Exception)
+    >>> def handle_error(e):


docs/error-reporting-usage.rst

+
+    >>> @app.errorhandler(Exception)
+    >>> def handle_error(e):
+    >>>     client = error_reporting.Client()


error_reporting/google/cloud/error_reporting/__init__.py


 """Client library for Stackdriver Error Reporting"""

+from google.cloud.error_reporting.client import Client, HTTPContext


error_reporting/unit_tests/__init__.py

 # See the License for the specific language governing permissions and
 # limitations under the License.
+
+


error_reporting/unit_tests/test_client.py

        self.assertLess(report_location['lineNumber'], 150)


+class TestFlaskHelper(unittest.TestCase):


error_reporting/unit_tests/test_client.py

+
+    def test_flask_helper(self):
+        from google.cloud.error_reporting import build_flask_context
+        request = _Request('http://google.com', 'GET',


error_reporting/unit_tests/test_client.py


+class TestFlaskHelper(unittest.TestCase):
+
+    def test_flask_helper(self):


error_reporting/unit_tests/test_client.py

+        self.assertEqual(request.remote_addr, context.remoteIp)
+
+
+# Fake request so no need to bring in Werkzeug as dependency


error_reporting/google/cloud/error_reporting/util.py

+from google.cloud.error_reporting.client import HTTPContext
+
+
+def build_flask_context(request):


error_reporting/google/cloud/error_reporting/__init__.py

-                       referrer=request.referrer,
-                       remote_ip=request.remote_addr)
+from google.cloud.error_reporting.client import Client
+from google.cloud.error_reporting.client import HTTPContext


error_reporting/unit_tests/test_util.py

+import unittest
+
+
+class TestFlaskHelper(unittest.TestCase):


error_reporting/unit_tests/test_util.py

+
+    def test_flask_helper(self):
+        from google.cloud.error_reporting.util import build_flask_context
+        user_agent = _UserAgent('Google Cloud Unit Tests Agent')


error_reporting/unit_tests/test_util.py

+class TestFlaskHelper(unittest.TestCase):
+
+    def test_flask_helper(self):
+        from google.cloud.error_reporting.util import build_flask_context


waprin · 2016-11-22T22:41:22Z

@dhermes ping whenever is convenient. hit most review comments but wasn't sure about test class naming conventions, looked at a few and didn't seen an obvious consistency I was breaking.

error_reporting/google/cloud/error_reporting/util.py

+from google.cloud.error_reporting.client import HTTPContext
+
+
+def build_flask_context(request):


error_reporting/unit_tests/test_util.py

+import unittest
+
+
+class TestFlaskHelper(unittest.TestCase):


docs/error-reporting-util.rst

@@ -0,0 +1,6 @@
+Error Reporting Client


docs/error-reporting-usage.rst

+
+ .. code-block:: python
+
+    >>> from google.cloud.error_reporting.util import build_flask_context


error_reporting/google/cloud/error_reporting/__init__.py


 """Client library for Stackdriver Error Reporting"""

-


error_reporting/tox.ini

 deps =
    {toxinidir}/../core
-    {toxinidir}/../logging
+    {toxinidir}/../logging  


waprin · 2016-12-01T22:23:08Z

@dhermes merge?

Add Flask Helper to Error Reporting

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 17, 2016

waprin force-pushed the flask_errors branch from 3006a73 to 3464366 Compare November 18, 2016 00:26

daspecster added the error reporting label Nov 18, 2016

dhermes reviewed Nov 18, 2016

View reviewed changes

dhermes reviewed Nov 21, 2016

View reviewed changes

waprin force-pushed the flask_errors branch 3 times, most recently from 57b1a0e to 27f7917 Compare November 22, 2016 22:03

dhermes reviewed Nov 23, 2016

View reviewed changes

waprin force-pushed the flask_errors branch 3 times, most recently from d4402c5 to a7e7acc Compare November 23, 2016 20:25

dhermes approved these changes Nov 23, 2016

View reviewed changes

Add Flask Helper to Error Reporting

354b5cd

waprin force-pushed the flask_errors branch from a7e7acc to 354b5cd Compare November 23, 2016 22:21

dhermes approved these changes Dec 1, 2016

View reviewed changes

dhermes merged commit 7b74630 into googleapis:master Dec 1, 2016

dhermes added api: clouderrorreporting Issues related to the Error Reporting API. and removed api: clouderrorreporting Issues related to the Error Reporting API. labels Feb 23, 2017

richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017

Merge pull request googleapis#2751 from waprin/flask_errors

d8a3e8b

Add Flask Helper to Error Reporting


		"""Client library for Stackdriver Error Reporting"""

		from google.cloud.error_reporting.client import Client, HTTPContext

		# See the License for the specific language governing permissions and
		# limitations under the License.

		self.assertLess(report_location['lineNumber'], 150)


		class TestFlaskHelper(unittest.TestCase):


		class TestFlaskHelper(unittest.TestCase):

		def test_flask_helper(self):

		self.assertEqual(request.remote_addr, context.remoteIp)


		# Fake request so no need to bring in Werkzeug as dependency

		from google.cloud.error_reporting.client import HTTPContext


		def build_flask_context(request):


		.. code-block:: python

		>>> from google.cloud.error_reporting.util import build_flask_context

Add Flask Helper to Error Reporting #2751

Add Flask Helper to Error Reporting #2751

Uh oh!

Conversation

waprin commented Nov 17, 2016

Uh oh!

daspecster commented Nov 18, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

waprin commented Nov 22, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

waprin commented Dec 1, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants