Adding docs for the Runtime Config API. #2689
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The runtimeconfig-usage doc (or the `runtimeconfig/google/cloud/runtimeconfig/__init__.py` file) should add some examples of library usage.
dhermes
added
docs
api: runtimeconfig
googlebot
added
the
cla: yes
Contributor
Author
|
Note the only failure here has been resolved in #2020, which @daspecster just merged. This is good to merge if anyone can review. |
daspecster
approved these changes
Nov 4, 2016
Contributor
daspecster
left a comment
daspecster
left a comment
There was a problem hiding this comment.
LGTM just the one question.
| @@ -0,0 +1,6 @@ | |||
| Variables | |||
| ~~~~~~~~~ | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
richkadel
pushed a commit
to richkadel/google-cloud-python
that referenced
this pull request
May 6, 2017
Adding docs for the Runtime Config API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The runtimeconfig-usage doc (or the
runtimeconfig/google/cloud/runtimeconfig/__init__.pyfile) should add some examples of library usage.@tswast once this is merged, care to take the reins on adding some usage examples?