Skip to content

Conversation

@omaray
Copy link
Contributor

@omaray omaray commented Oct 26, 2016

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 26, 2016
@daspecster
Copy link
Contributor

Holla at @omaray!

@daspecster daspecster added the api: logging Issues related to the Cloud Logging API. label Oct 26, 2016
Copy link
Contributor

@daspecster daspecster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM but I'll follow it up with the docs updates per https://github.com/GoogleCloudPlatform/google-cloud-python/search?utf8=%E2%9C%93&q=v2beta1

@omaray
Copy link
Contributor Author

omaray commented Oct 26, 2016

Thanks! Should have done a search too for the doc updates. Thanks for doing those.

@dhermes dhermes merged commit b2662c1 into googleapis:master Oct 26, 2016
@dhermes
Copy link
Contributor

dhermes commented Oct 26, 2016

Way to go @omaray!

richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
Change the version of the Logging API from v2beta1 to v2
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
parthea pushed a commit that referenced this pull request Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: logging Issues related to the Cloud Logging API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants