-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Cut 0.20.1 datastore release. #2530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@tseaver Not sure what the right move is for getting the release note content. Looking at the history for the https://github.com/GoogleCloudPlatform/google-cloud-python/commits/master/datastore it seems like #2423 and #2496 are the only relevant changes. From the CLI: it indicates #2423 was already in the |
|
Draft of release note: Datastore 0.20.1
|
|
LGTM |
|
@tseaver What tag should I push? |
|
I just pushed https://pypi.python.org/pypi/google-cloud-datastore/0.20.1 via |
|
@dhermes I guess |
|
@dhermes |
|
@tseaver both are PEP420 invalid. The "best" valid choice is >>> from packaging.version import Version
>>> v = Version('0.20.1-datastore')
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/usr/local/lib/python2.7/dist-packages/packaging/version.py", line 202, in __init__
raise InvalidVersion("Invalid version: '{0}'".format(version))
packaging.version.InvalidVersion: Invalid version: '0.20.1-datastore'
>>> v = Version('datastore-0.20.1')
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/usr/local/lib/python2.7/dist-packages/packaging/version.py", line 202, in __init__
raise InvalidVersion("Invalid version: '{0}'".format(version))
packaging.version.InvalidVersion: Invalid version: 'datastore-0.20.1'I am pretty 👎 on tagging twice just for name aliasing. However, I was under the impression that in #2462 we said we might ignore the |
|
If we tag the umbrella project with PEP-420 compatible tags at "appropriate" points, that would let us trigger RTD rebuilds for |
|
Not sure what you mean here. We can only tag one project / GitHub repo. It seems like you're suggesting having docs only tags separate from release only tags (on our |
|
If we tag sub-project releases in a way that doesn't cause RTD to rebuild |
|
So you're saying |
Cut 0.20.1 datastore release.
/cc @jonparrott
Note we still don't have an automated story for
twineuploads (and can't really get one until we straighten out tags)