Skip to content

Conversation

@dhermes
Copy link
Contributor

@dhermes dhermes commented Oct 6, 2016

Fixes #2502.

@dhermes dhermes added the testing label Oct 6, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 6, 2016
@tseaver
Copy link
Contributor

tseaver commented Oct 6, 2016

pycodestyle is no longer checking the whole tree (.git, .tox/ envs, etc.)

@daspecster
Copy link
Contributor

daspecster commented Oct 6, 2016

@tseaver, do you think this is related to the strange behavior I saw in #2504?

@dhermes dhermes mentioned this pull request Oct 6, 2016
@dhermes
Copy link
Contributor Author

dhermes commented Oct 6, 2016

@daspecster Indeed it's the same behavior (though it isn't strange).

@tseaver PTAL, fixed the problem in the second commit. As the commit message says, this was an unintended side-effect of #2486.

@dhermes dhermes merged commit c441a39 into googleapis:master Oct 6, 2016
@dhermes dhermes deleted the fix-2502 branch October 6, 2016 15:55
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
Adding back local dependencies to system test tox envs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement. testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants