Allowing local env. vars. to be used for running unit tests. #2488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Contributor
|
LGTM aside from the conflict. |
dhermes
force-pushed
the
allow-local-env-for-unit-tests
branch
from
4289d2a to
56c1af2
Compare
Contributor
Author
|
@tseaver Do you mind also weighing in here? I feel like this is worth a discussion. |
tseaver
approved these changes
Oct 4, 2016
Contributor
Author
|
I hope I don't forgot to incorporate the dep. graph stuff here as well. |
richkadel
pushed a commit
to richkadel/google-cloud-python
that referenced
this pull request
May 6, 2017
…nit-tests Allowing local env. vars. to be used for running unit tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2487 could be incorporated into this as well, since we should follow the dependencies from the local diff