Use 'diff_base' for pycodestyle check, if set. #2486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Speeds it up, plus reduces spew when testing locally.
googlebot
added
the
cla: yes
daspecster
reviewed
Oct 3, 2016
scripts/pycodestyle_on_repo.py
Outdated
| os.chdir(git_root) | ||
| python_files = subprocess.check_output(['git', 'ls-files', '*py']) | ||
| python_files = python_files.strip().split() | ||
| candidates, _ = get_files_for_linting() |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
|
@tseaver I recently introduced |
dhermes
reviewed
Oct 4, 2016
scripts/pycodestyle_on_repo.py
Outdated
| import subprocess | ||
| import sys | ||
|
|
||
| from script_utils import get_files_for_linting |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
dhermes
reviewed
Oct 4, 2016
scripts/script_utils.py
Outdated
| be used. | ||
| :rtype: pair | ||
| :returns: Tuple of the diff base using the the list of filenames to be |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Also, fix a "the the" typo.
dhermes
added a commit
to dhermes/google-cloud-python
that referenced
this pull request
Oct 5, 2016
Issue introduced in googleapis#2486.
dhermes
added a commit
to dhermes/google-cloud-python
that referenced
this pull request
Oct 6, 2016
Was an unintended side-effect of googleapis#2486.
dhermes
added a commit
to dhermes/google-cloud-python
that referenced
this pull request
Oct 6, 2016
Was an unintended side-effect of googleapis#2486.
dhermes
added a commit
to dhermes/google-cloud-python
that referenced
this pull request
Oct 6, 2016
Issue introduced in googleapis#2486.
richkadel
pushed a commit
to richkadel/google-cloud-python
that referenced
this pull request
May 6, 2017
Was an unintended side-effect of googleapis#2486.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speeds it up, plus reduces spew when testing locally.