Skip to content

Removing custom generated long-running operations.#2427

Merged
dhermes merged 1 commit into
googleapis:masterfrom
dhermes:drop-custom-operations-code
Sep 26, 2016
Merged

Removing custom generated long-running operations.#2427
dhermes merged 1 commit into
googleapis:masterfrom
dhermes:drop-custom-operations-code

Conversation

@dhermes

@dhermes dhermes commented Sep 26, 2016

Copy link
Copy Markdown
Contributor

H/T to @bjwatson for pointing out this needs to be done

@dhermes dhermes added the api: bigtable Issues related to the Bigtable API. label Sep 26, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 26, 2016
@tseaver

tseaver commented Sep 26, 2016

Copy link
Copy Markdown
Contributor

LGTM pending Travis. I'm assuming you verified that the system tests for Bigtable pass with this change.

@dhermes

dhermes commented Sep 26, 2016

Copy link
Copy Markdown
Contributor Author

@tseaver I hadn't until you mentioned it, but just did to verify. All good.

@dhermes dhermes merged commit eec16d0 into googleapis:master Sep 26, 2016
@dhermes dhermes deleted the drop-custom-operations-code branch September 26, 2016 20:00
parthea pushed a commit that referenced this pull request Apr 1, 2026
Thank you for opening a Pull Request! Before submitting your PR, there
are a few things you can do to make sure it goes smoothly:
- [ ] Make sure to open an issue as a
[bug/issue](https://github.com/googleapis/python-bigquery-dataframes/issues/new/choose)
before writing your code! That way we can discuss the change, evaluate
designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants